Skip to content
This repository was archived by the owner on Oct 27, 2025. It is now read-only.

chore: fixes to tests #289

Merged
peintnermax merged 10 commits into from
Dec 6, 2024
Merged

chore: fixes to tests #289

peintnermax merged 10 commits into from
Dec 6, 2024

Conversation

@stebenz
Copy link
Contributor

@stebenz stebenz commented Nov 20, 2024 •
edited
Loading

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • Vitest unit tests ensure that components produce expected outputs on different inputs.
  • Cypress integration tests ensure that login app pages work as expected. The ZITADEL API is mocked.
  • No debug or dead code
  • My code has no repetitions

@vercel
Copy link

vercel bot commented Nov 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
typescript-login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 1:20pm

@peintnermax peintnermax marked this pull request as ready for review December 6, 2024 13:27
@peintnermax peintnermax merged commit 84c05d8 into main Dec 6, 2024
8 checks passed
@peintnermax peintnermax deleted the acceptance-test-suite branch December 6, 2024 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@peintnermax peintnermax peintnermax approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stebenz @peintnermax