Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using master when a project has no tags is problematic #236

Open
stackotter opened this issue Apr 5, 2022 · 1 comment
Open

Using master when a project has no tags is problematic #236

stackotter opened this issue Apr 5, 2022 · 1 comment

Comments

@stackotter
Copy link

It is becoming increasingly common that git repositories use main as the default branch instead of master. If a package has no tags and someone tries to install it using mint, mint only attempts to checkout the master branch which of course fails if the package uses main instead of master.

I think it would be sensible to either just use the repository's default branch (the one that is automatically checked out after git clone [repo] iirc), or add an option to specify a branch when installing a package.
@stackotter
Copy link
Author

Whoops, I didn't see #204. It seems like that PR had trouble implementing my first suggested solution. Would it perhaps be easier to attempt the second option? That is: just use master if no tags are found, but allow the user to override the fallback branch with a --fallback-branch option (or something along those lines).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stackotter