Skip to content

Relies on the pipes module, removed from the standard library in Python 3.13 #119

Open
@musicinmybrain

Description

$ gh repo clone xolox/python-coloredlogs
$ cd python-coloredlogs
$ tox -e py312

(all tests pass)

$ tox -e py313
==================================================================================================== ERRORS ====================================================================================================
____________________________________________________________________________________ ERROR collecting coloredlogs/tests.py _____________________________________________________________________________________
ImportError while importing test module '/home/ben/src/forks/python-coloredlogs/coloredlogs/tests.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib64/python3.13/importlib/__init__.py:88: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
coloredlogs/tests.py:22: in <module>
    from humanfriendly.testing import PatchedAttribute, PatchedItem, TestCase, retry
.tox/py313/lib/python3.13/site-packages/humanfriendly/testing.py:28: in <module>
    import pipes
E   ModuleNotFoundError: No module named 'pipes'
=========================================================================================== short test summary info ============================================================================================
ERROR coloredlogs/tests.py
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
=============================================================================================== 1 error in 0.09s ===============================================================================================

I will follow up with a PR to replace pipes.quote with shlex.quote, as in xolox/python-humanfriendly#75. The shlex.quote() API is available from Python 3.3 on; pipes.quote() was never documented.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions