-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor core interface #41
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and add a test for it
I simplified the view classes and removed the data views. |
leotrs
commented
Feb 7, 2022
maximelucas
reviewed
Feb 7, 2022
maximelucas
approved these changes
Feb 7, 2022
maximelucas
reviewed
Feb 7, 2022
maximelucas
reviewed
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is pretty big so I suggest reviewing each commit in turn instead of the whole thing at once. This basically implements the behavior discussed here #40. In particular, there is (hopefully, I think), one way of accessing each thing. Among other things:
H['attr']
accesses hypergraph attributes.H.nodes()
andH.edges()
are no longer supportedH.nodes[]
andH.edges[]
now access attributesH.nodes.membership
is now the same asH.nodes.members
. (I decided to keep members for simplicity and symmetry withH.edges
)There are a few kinks to work out, but I thought this PR was already big enough.
As you review, please let me know if you think of any other test I should add to this PR.
Also: there's a lot of noise in this PR because I decided to change
*_attrs
to*_attr
just to be uniform with the variable names in the mainHypergraph
class.Closes #40