Updated add_simplices_from to match add_hyperedges_from #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om. Accepted input formats have changed
leotrs
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
Thanks for this. No comments, feel free to merge when ready.
My only thought is that now Hypergraph.add_edges_from and SimplicialComplex.add_simplices_from are VERY long and VERY similar, and it will be a pain to maintain both. This is precisely why we need a common interface for both classes....
Agreed of course |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
add_simplexandadd_simplices_from. Accepted input formats have changed to match the hypergraph methods.Also fixes #218, and the new format is to use
S.add_simplices_from([((1,2,3), {"color": "red"})], max_order=2).(I didn't try to speedup anything yet despite the name of the branch, because I found this discrepancy first)