Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial clique complex #200

Merged
merged 9 commits into from
Oct 24, 2022
Merged

Partial clique complex #200

merged 9 commits into from
Oct 24, 2022

Conversation

maximelucas
Copy link
Collaborator

Added an option to fill only some cliques with probabilities ps to xgi.flag_complex().

Started this branch a long time ago so we'll need to merge main, but easier to check the new code before that.

@leotrs
Copy link
Collaborator

leotrs commented Oct 24, 2022

Started this branch a long time ago so we'll need to merge main, but easier to check the new code before that.

An alternative is to rebase your branch over main, which gives a much cleaner commit :) Don't do it now tho since it usually does not play well with open PRs..

@maximelucas
Copy link
Collaborator Author

We'll have to try one day hehe. I've just resolved the conflicts now actually. You're too fast, had not seen your message :)

xgi/generators/classic.py Outdated Show resolved Hide resolved
xgi/generators/classic.py Outdated Show resolved Hide resolved
xgi/generators/classic.py Outdated Show resolved Hide resolved
Co-authored-by: Leo Torres <[email protected]>
@maximelucas maximelucas merged commit bba141c into main Oct 24, 2022
@maximelucas maximelucas deleted the partial_clique_complex branch October 24, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants