chore(b-form-spinbutton): add two missing props (bootstrap-vue#4784)

tmorehouse · web-flow · commit 88ea325f0d83 · 2020-02-18T01:30:23.000-04:00
diff --git a/src/components/form-spinbutton/form-spinbutton.js b/src/components/form-spinbutton/form-spinbutton.js
@@ -116,6 +116,14 @@ export const BFormSpinbutton = /*#__PURE__*/ Vue.extend({
       type: Boolean,
       default: false
     },
+    ariaLabel: {
+      type: String,
+      default: null
+    },
+    ariaControls: {
+      type: String,
+      default: null
+    },
     labelDecrement: {
       type: String,
       default: () => getComponentConfig(NAME, 'labelDecrement')
@@ -350,7 +358,13 @@ export const BFormSpinbutton = /*#__PURE__*/ Vue.extend({
       }
     },
     handleStepRepeat(evt, stepper) {
+      const { type, button } = evt || {}
       if (!this.disabled && !this.readonly) {
+        /* istanbul ignore if */
+        if (type === 'mousedown' && button) {
+          // We only respond to left (main === 0) button clicks
+          return
+        }
         this.resetTimers()
         // Enable body mouseup event handler
         this.setMouseup(true)
@@ -374,8 +388,14 @@ export const BFormSpinbutton = /*#__PURE__*/ Vue.extend({
         }, delay)
       }
     },
-    onMouseup() {
+    onMouseup(evt) {
       // `<body>` listener, only enabled when mousedown starts
+      const { type, button } = evt || {}
+      /* istanbul ignore if */
+      if (type === 'mouseup' && button) {
+        // we only care about left (main === 0) mouse button click
+        return
+      }
       this.resetTimers()
       this.setMouseup(false)
       // Trigger the change event
diff --git a/src/components/form-spinbutton/package.json b/src/components/form-spinbutton/package.json
@@ -66,6 +66,14 @@
             "prop": "vertical",
             "description": "When set, renders the component with a vertical layout"
           },
+          {
+            "prop": "ariaLabel",
+            "description": "Value to place in the `aria-label` attribute of the spinbutton"
+          },
+          {
+            "prop": "ariaControls",
+            "description": "If this component controls another component or element, set this to the ID of the controlled component or element"
+          },
           {
             "prop": "labelIncrement",
             "description": "Text to be used for the `aria-label` attribute on the increment button"
