Skip to content

Conversation

@swt2c
Copy link
Contributor

@swt2c swt2c commented Mar 30, 2023

No description provided.

@swt2c swt2c force-pushed the fedora_ci_gui_tests branch 5 times, most recently from 2246cfe to 19c5a13 Compare April 4, 2023 23:19
swt2c added 3 commits April 4, 2023 19:20
Previously the extension loading fallback would only try the first
directory and then give up.
For some reason, calling HasSelection() immediately after SelectAll()
causes the web extension to get stuck under WebKit 2.40.  Instead of
sleeping, call wxYield() a few times to let the event loop run a bit.
@swt2c swt2c force-pushed the fedora_ci_gui_tests branch from 19c5a13 to d352f58 Compare April 11, 2023 02:09
It seems the window size isn't sorted out quite yet when the test
starts, so GetCountPerPage() was returning one too few.
@swt2c swt2c force-pushed the fedora_ci_gui_tests branch from d352f58 to d6264de Compare April 11, 2023 23:37
@vadz
Copy link
Contributor

vadz commented May 10, 2025

@swt2c Do you plan to return to this?

@swt2c
Copy link
Contributor Author

swt2c commented May 11, 2025

Maybe eventually. I think the issue I ran into was that when I went to debug this locally, I ran into a bunch more test failures locally. I'm not really sure why. Perhaps HiDPI related or Wayland related?

In any event, feel free to close this PR if it's been open too long without resolution. 😁

@vadz
Copy link
Contributor

vadz commented May 11, 2025

We can keep it open, it doesn't really cost us anything, I just wasn't sure if this wasn't completely abandoned.

FWIW the tests using wxUIActionSimulator only run under X11, not Wayland, so you either need to run them with GDK_BACKEND=x11 (to run the tests) or WX_UI_TESTS=0 (to skip them). You also need to run the tests from the tests subdirectory (which is annoying and I keep meaning to fix this and postponing it...). But otherwise they are supposed to work, and do work for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants