-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update esbuild target for Deno #7687
Conversation
🦋 Changeset detectedLatest commit: 7360ae0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There's a set of tests failing in an area of the code I didn't touch - are we seeing this on other PRs as well? Thanks! |
Yep, sorry - my fault. We had a regression in our Markdoc integration. I went ahead and updated your branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is probably fine as Deno 1.0 already supports many modern syntax from the start 🤔
Hey team! Any chance we could see this merged and shipped soon? Would love to update our template app. |
I was hoping to get another eye on this from another maintainer, in case I miss something, but looks like it should be safe. Will merge this one. |
Thanks a ton @bluwy! |
Changes
Updates the build target for esbuild from
es2020
toesnext
to allow for more advanced language features that are available in Deno.Testing
Added a test that includes a language feature supported in
esnext
, in this case a top-level await.Docs
This change doesn't require updates to the documentation - a Deno user would reasonably assume that all runtime features that work in Deno would work during the Astro build process as well.