Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infra lacks a "JSON stringify and UTF-8 encode to bytes" operation #193

Closed
equalsJeffH opened this issue Mar 5, 2018 · 3 comments · Fixed by #207 or w3c/webauthn#1017
Closed

Infra lacks a "JSON stringify and UTF-8 encode to bytes" operation #193

equalsJeffH opened this issue Mar 5, 2018 · 3 comments · Fixed by #207 or w3c/webauthn#1017
Labels
good first issue Ideal for someone new to a WHATWG standard or software project

Comments

@equalsJeffH
Copy link
Contributor

Infra features a parse JSON from bytes operation, but lacks a "JSON stringify and UTF-8 encode to bytes" operation.

see also webauthn issue #712 JSON-serialized client data is wrong
@equalsJeffH equalsJeffH mentioned this issue Mar 5, 2018
Closed
@annevk
Copy link
Member

annevk commented Mar 7, 2018

If someone wants to fix this, w3c/webauthn#712 (comment) has instructions.

@annevk annevk added the good first issue Ideal for someone new to a WHATWG standard or software project label Mar 7, 2018
@jakearchibald
Copy link
Contributor

Is it ok to call out to ECMAScript here? Wouldn't that fail in in-parallel steps?

@jakearchibald jakearchibald mentioned this issue May 17, 2018
Closed
@annevk
Copy link
Member

annevk commented May 17, 2018

I think in theory it should be okay since we don't rely on any global state here. But it might be worth calling it out explicitly indeed.

@jakearchibald jakearchibald mentioned this issue May 17, 2018
Open
@equalsJeffH equalsJeffH mentioned this issue Jul 17, 2018
Merged
@equalsJeffH equalsJeffH mentioned this issue Jul 27, 2018
Merged
domenic pushed a commit that referenced this issue Aug 2, 2018
@equalsJeffH @domenic
Add "serialize JSON to bytes" algorithm
25f6859 
Fixes #193.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Ideal for someone new to a WHATWG standard or software project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add 'JSON stringify and UTF-8 encode to bytes' algorithm equalsJeffH/infra
fix #712 JSON-serialized client data is wrong w3c/webauthn
3 participants
@jakearchibald @equalsJeffH @annevk