Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"browsing context scope origin" is currently a no-op #4703

Open
annevk opened this issue Jun 14, 2019 · 0 comments
Open

"browsing context scope origin" is currently a no-op #4703

annevk opened this issue Jun 14, 2019 · 0 comments
Labels
needs tests Moving the issue forward requires someone to write tests topic: navigation

Comments

@annevk
Copy link
Member

annevk commented Jun 14, 2019

@JuniorHsu I was looking at how HTML invokes fetch from its navigate algorithm to see if there was anything around origins we were overlooking thus far and found this:

An element has a browsing context scope origin if its Document's browsing context is a top-level browsing context or if all of its Document's ancestor browsing contexts all have active documents whose origin are the same origin as the element's node document's origin. If an element has a browsing context scope origin, then its value is the origin of the element's node document.

I think the intent is that if there's a navigation from a frame that's cross-origin with one of its ancestors there's no origin, though the exact way this concept is currently used and worded makes it a no-op. I suspect this regressed when rewriting things to use the Fetch Standard.

We probably need to test what happens in such scenarios (a non-top-level frame that's cross-origin with one if its ancestors) with regards to the Origin header as that's the only thing a request's origin concept is used for when it comes to navigation if I remember correctly.

(I don't think making Origin follow Referrer Policy as discussed at whatwg/fetch#908 needs to block on this however.)

cc @zetafunction @yutakahirano

@annevk annevk added topic: navigation needs tests Moving the issue forward requires someone to write tests labels Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs tests Moving the issue forward requires someone to write tests topic: navigation
Development

No branches or pull requests

1 participant