DMND-1721 Successfully creating RSD & Collections and adding skills t… #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o collections locally; JUnits still failing locally though
shnooga
requested review from
JohnKallies,
campeterson22,
jesusgudino and
jchavez137
campeterson22
approved these changes
Sep 11, 2023
jesusgudino
approved these changes
Sep 11, 2023
Thank you |
… moved to other packages.
…oot3.1.2' into feature/DMND-1721_java17_springboot3.1.2 # Conflicts: # api/src/main/kotlin/edu/wgu/osmt/jobcode/JobCodeEsRepo.kt
…ble to search for collection and skills without exceptions. Need further testing with PostMan
… is entered for Collection Log request.
… entered for Skill Log request.
… JUnit still now working
#455) * DMND-1779 Utilizing application.properties to set the new Easticsearch RestClient in ElasticsearchClientManager.kt * Bug fix, using StringQuery(str) for old ES 7.x causes the the search template to ignore the filter property; fixed for FindsAllByPublishStatus but needs to update the more complex CollectionEsRepo and RichSkilsEsRepo. * Code clean up * More clean up * Update code to handle filter queries and not inadvertently ignore it as before * More cleanup * DMND-1793 Upgrade github work flow to use JDK17 * Created CustomKeywordRepositoryImpl.typeAheadSearchNu() to replace deprecated typeAheadSearch() as sample code for upgrading to ElasticSearch v8.7.X * Add/remove comments for clarifications --------- Co-authored-by: Huey <[email protected]>
* fix SecurityConfig.kt methods * fix http:// url ES clientmanager
* Replacing the buggy convertToStringQuery method because it is missing the PageAble property. * Adding methods for migration to ElasticSearch v8.7.X * Clean up * Clean up * Code refactor for readability and ease of upgrade to ElasticSearch v8.7.x * Code refactoring to facilitate future migration to Elastic Search v8.7.X API * DMND-1782 working --------- Co-authored-by: Huey <[email protected]>
* Upgrade testcontainers to 1.18.3 (#453) * Add additional logging for env file sourcing in GH Action builds (#457) * Use 'debug' Spring profile for logging properties to console (#461) * Update pathings to allow POST of skills/filter and GET of Categories & Workspace * Code refactor for maintainability --------- Co-authored-by: John Kallies <[email protected]> Co-authored-by: Huey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o collections locally; JUnits still failing locally though