Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Metadata Admin Screens to OSMT #430

Draft
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

Corpratespaz
Copy link
Contributor

@Corpratespaz Corpratespaz commented Jun 30, 2023

1. Create infrastructure

2. Create abstract implementations

3. Create concrete implementations

@manuel-delvillar manuel-delvillar force-pushed the feature/admin-screens branch 3 times, most recently from ab69586 to 2fec338 Compare July 11, 2023 20:17
@manuel-delvillar manuel-delvillar force-pushed the feature/admin-screens branch 2 times, most recently from 7d8e4cf to ba02a07 Compare July 19, 2023 17:01
jchavez137 and others added 19 commits July 25, 2023 16:46
* Adding new services classes for jobCodes and namedReferences

* Renaming package and services name classes. Extending new abstract class from the existing one.

* refactoring JobCode classes and package. Adding CRUD requests

* Adding Enum for MetadataType, Optimizing Imports

* Adding implementation for delete method in Abstract service

* Adding new services classes for jobCodes and namedReferences

* Renaming package and services name classes. Extending new abstract class from the existing one.

* refactoring JobCode classes and package. Adding CRUD requests

* Adding Enum for MetadataType, Optimizing Imports

* updating openapi.yaml to match endpoint definition.

* Correcting Routepath and refactoring web methods

* Refactoring entry points in navigation bar
* Adding new services classes for jobCodes and namedReferences

* Renaming package and services name classes. Extending new abstract class from the existing one.

* refactoring JobCode classes and package. Adding CRUD requests

* adding providers for unit testing in abstract-data.service.spec.ts

* Adding Enum for MetadataType, Optimizing Imports

* Adding implementation for delete method in Abstract service

* Remove unused code

- Remove ApiGetParams.

- Constructor in abstract.service now is protected.

* Add alias for test directory

* Adding new services classes for jobCodes and namedReferences

* Renaming package and services name classes. Extending new abstract class from the existing one

* updating openapi.yaml to match endpoint definition

* Correcting Routepath and refactoring web methods

* Correcting buildTableParams sort param

* Updating endpoints call to match definition

---------

Co-authored-by: manuel-delvillar <[email protected]>
* Add paths for jobcodes

* Add paths for named references

* Enable EnableGlobalMethodSecurity
* Working with pagination

* Add sort insensitive

* Add job code level and parents

* Delete job code

* Fix delete test

* Remove PaginatedJobCodes

* Show job codes in list

* Request all on clear search

* Delete job code by id

- Add id in ApiJobCode (ui & api)

- Call request to delete in ui

* Show toast when job code is deleted

* Add confirm message & reload on delete

* Fix broken tests

* Update open API

* Update table job codes

- Sort by code

- Remove framework name column

* Show parents

- Add pipe to show parents

* Sort by job code level

* Add validation to delete a job code

- You cannot delete a jobcode with RSDs

- You cannot delete a job code with children

* Fix create from api

* Add error messages on delete job code

* Add test new functions back end

* Update texts

* Update values for MetadataType

* Add new tests

* Fix broken tests

* Remove unused import

* Add id property for job code in open api

- Requests are without id and responses are with id.

* Delete multiple job codes

* Improve notifications on delete

* Add back to top

* Add abstract list

* Fix text on action

* Clean selected data after delete one or more job codes

* Fix table

* Disable delete single if select all is checked

* Add property to job code in open api

- Matching query is updated until we search, not while we type.

- If select all is selected and unselect one job code, select all is unchecked.

- Disable dots menu if is without actions.

* Uncheck select all if items change

* Check all selected if all are selected
* Refactoring Controller to accept keyword type

* Renaming Keyword RoutePaths

* Addind overloaded typeAheadSearch method with pageable

* Working on UI, adding service endpoint calls, adding service to NR table components.

* Converting delete process to be task result, adjusting labels for plural category

* removing unused named reference service, fixing enum issue, fixing case insensitive sort..

* adding unit tests

* Removing unused code for category screens, updating API yaml file

* Removing hardcoded totalPageCount for named reference table, removing unused imports.

* Reverting skillCount field back, fixing some PR comments, updating openapi.yaml

* Removing unused imports.

* Removing unused imports.

* Refactoring deletion logic, fixing mock data.

* Removing comented out line

* Removing unused RoutePath

* Add postman tests for job codes

* Adding test coverage scripts

* Adding test coverage scripts

* Adding test coverage scripts

* Correcting scripts.

* Removing category script tests, No more needed.

* Fix job code tests

* Add pre request in id folder

* Fix get pagination

- Remove query parameter

* Updating update keyword test.

---------

Co-authored-by: manuel-delvillar <[email protected]>
- Add version to JobCodeController & KeywordController.

- Update RoutePaths
- Remove files in api-test that are not used.
- Add JobCodeV2

- Add ApiJobCodeV2
- Update expected data on similarities/results
- Update services to support versioning
- Update tests to support versioning
* Refactor of Category detail view for metadata

* Fixed button roles auth levels

* Refactor Category to Metadata

---------

Co-authored-by: manuel-delvillar <[email protected]>
* Add create named reference

* Edit metadata

* Improve create button

- Improve create metadata position and size in ui.

* Show name of edited metadata

* Load related skills

* Search related skills

* Load information in public view

* Fix broken ui tests

* Update API tests

- Add test to KeywordController.

- Update open api v3.

* Reindex related RSDs after update keyword

* Add test create-named-reference
@Corpratespaz Corpratespaz force-pushed the feature/admin-screens branch from 63926d9 to 6c240d5 Compare July 25, 2023 14:47
* Metadata selector sorted by alphabetical order.

- URI and Framework only available for Alignment.

- Add dot after metadataCountLabel.

* Add copy public url

* Sort correctly metadata selector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants