Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Change]: Update column sorting for all tables #1849

Open
8 tasks
Shrinks99 opened this issue Jun 4, 2024 · 4 comments
Open
8 tasks

[Change]: Update column sorting for all tables #1849

Shrinks99 opened this issue Jun 4, 2024 · 4 comments
Assignees
Labels
back end Requires back end dev work enhancement New feature or request front end Requires front end dev work

Comments

@Shrinks99
Copy link
Member

Shrinks99 commented Jun 4, 2024

Context

Now that #1839 introduces sorting using the table headers, we should extend this function to the other tables within the app to ensure a consistent and predictable experience.

Mockup for the spreadsheet table style

Screenshot 2024-06-04 at 3 47 45 PM

Tasks

@Shrinks99 Shrinks99 added enhancement New feature or request front end Requires front end dev work labels Jun 4, 2024
@Shrinks99 Shrinks99 moved this from Triage to Ready in Webrecorder Projects Jun 4, 2024
@tw4l tw4l self-assigned this Jun 4, 2024
@tw4l tw4l added the back end Requires back end dev work label Jun 4, 2024
@ikreymer ikreymer moved this from Ready to Todo in Webrecorder Projects Jun 4, 2024
@tw4l
Copy link
Member

tw4l commented Jun 4, 2024

Assigned to me to investigate what backend sorting changes will be necessary.

@tw4l tw4l moved this from Todo to Ready in Webrecorder Projects Jul 16, 2024
@tw4l
Copy link
Member

tw4l commented Aug 15, 2024

Notes on changes that will be necessary for this:

Archived Items

In table, not sortable

  • Name (with firstSeedURL + x URLs fallback)
  • Pages crawled

Sortable, not in table

  • Last Analysis Run

Workflows

In table, not sortable

  • Name (with firstSeedURL + x URLs fallback)
  • Schedule (also condensed with Name)
  • Total size

Sortable, not in table

  • Crawl Start URL
  • Date created

Collections

In table, not sortable

  • Number of archived items
  • Total pages

Archived Items tab on the Collections page

Notes

  • Same thing as Archived Items table but doesn't have sorting in-place currently

Pages list in the Quality Assurance tab of the Archived Item Detail page

Sortable, not in table

  • Recently Approved? (maybe just needs rename, or make sorting by date more apparent? - maybe should just be Approval)
  • Most Comments (just Comments in table, existing backend filter is just for has comments or not, not sortable by number of comments)

Notes

  • Title and URL collapsed into one column in current view

Crawls tab on the Crawl Workflow Detail page

In table, not sortable

  • Duration
  • Pages crawled
  • createdBy

Org Settings members list

Notes

  • Not currently using a backend endpoint, just getting this as part of org response
  • Likely need a new /orgs/oid/users endpoint to support sorting

Btrix queue exclusion table

Notes

  • Does this need to be sortable? I think these might be fetched from redis currently rather than stored in database

@Shrinks99
Copy link
Member Author

Generally we don't seem to be using many pages of exclusions so I'm not too worried about that table not being sortable. If it's easy to do, great to have for consistency, otherwise seems like low priority to me.

@tw4l
Copy link
Member

tw4l commented Oct 2, 2024

Pull out high priority items into sub-issues and then unschedule this main issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back end Requires back end dev work enhancement New feature or request front end Requires front end dev work
Projects
Status: Ready
Development

No branches or pull requests

2 participants