refactor!: [emoji] was removed without replacements, please use custom function if you need this

alexander-akait · alexander-akait · commit d19e92f595ef · 2021-10-20T16:25:00.000+03:00
diff --git a/README.md b/README.md
@@ -150,8 +150,6 @@ The following tokens are replaced in the `name` parameter:
 - `[path]` the path of the resource relative to the `context` query parameter or option.
 - `[folder]` the folder the resource is in
 - `[query]` the queryof the resource, i.e. `?foo=bar`
-- `[emoji]` a random emoji representation of `options.content`
-- `[emoji:<length>]` same as above, but with a customizable number of emojis
 - `[contenthash]` the hash of `options.content` (Buffer) (by default it's the hex digest of the md4 hash)
 - `[<hashType>:contenthash:<digestType>:<length>]` optionally one can configure
   - other `hashType`s, i. e. `sha1`, `md4`, `md5`, `sha256`, `sha512`
@@ -190,14 +188,6 @@ loaderUtils.interpolateName(loaderContext, "html-[hash:6].html", { content: ...
 loaderUtils.interpolateName(loaderContext, "[hash]", { content: ... });
 // => c31e9820c001c9c4a86bce33ce43b679
 
-// loaderContext.resourcePath = "/absolute/path/to/app/img/image.gif"
-loaderUtils.interpolateName(loaderContext, "[emoji]", { content: ... });
-// => &#128077;
-
-// loaderContext.resourcePath = "/absolute/path/to/app/img/image.gif"
-loaderUtils.interpolateName(loaderContext, "[emoji:4]", { content: ... });
-// => &#128589;&#127970;&#128228;&#128029;
-
 // loaderContext.resourcePath = "/absolute/path/to/app/img/image.png"
 loaderUtils.interpolateName(loaderContext, "[sha512:hash:base64:7].[ext]", { content: ... });
 // => 2BKDTjl.png
diff --git a/lib/interpolateName.js b/lib/interpolateName.js
@@ -1,40 +1,8 @@
 "use strict";
 
 const path = require("path");
-const emojisList = require("emojis-list");
 const getHashDigest = require("./getHashDigest");
 
-const emojiRegex = /[\uD800-\uDFFF]./;
-const emojiList = emojisList.filter((emoji) => emojiRegex.test(emoji));
-const emojiCache = {};
-
-function encodeStringToEmoji(content, length) {
-  if (emojiCache[content]) {
-    return emojiCache[content];
-  }
-
-  length = length || 1;
-
-  const emojis = [];
-
-  do {
-    if (!emojiList.length) {
-      throw new Error("Ran out of emoji");
-    }
-
-    const index = Math.floor(Math.random() * emojiList.length);
-
-    emojis.push(emojiList[index]);
-    emojiList.splice(index, 1);
-  } while (--length > 0);
-
-  const emojiEncoding = emojis.join("");
-
-  emojiCache[content] = emojiEncoding;
-
-  return emojiEncoding;
-}
-
 function interpolateName(loaderContext, name, options) {
   let filename;
 
@@ -111,9 +79,6 @@ function interpolateName(loaderContext, name, options) {
         /\[(?:([^:\]]+):)?(?:hash|contenthash)(?::([a-z]+\d*))?(?::(\d+))?\]/gi,
         (all, hashType, digestType, maxLength) =>
           getHashDigest(content, hashType, digestType, parseInt(maxLength, 10))
-      )
-      .replace(/\[emoji(?::(\d+))?\]/gi, (all, length) =>
-        encodeStringToEmoji(content, parseInt(length, 10))
       );
   }
 
diff --git a/package.json b/package.json
@@ -5,7 +5,6 @@
   "description": "utils for webpack loaders",
   "dependencies": {
     "big.js": "^6.1.1",
-    "emojis-list": "^3.0.0",
     "json5": "^2.2.0"
   },
   "scripts": {
diff --git a/test/interpolateName.test.js b/test/interpolateName.test.js
@@ -2,8 +2,6 @@
 
 const loaderUtils = require("../");
 
-const emojiRegex = /[\uD800-\uDFFF]./;
-
 describe("interpolateName()", () => {
   function run(tests) {
     tests.forEach((test) => {
@@ -273,21 +271,6 @@ describe("interpolateName()", () => {
       "[unrecognized]",
       "should not interpolate unrecognized token",
     ],
-    [
-      [{}, "[emoji]", { content: "test" }],
-      (result) => {
-        expect(emojiRegex.test(result)).toBe(true);
-      },
-      "should interpolate [emoji]",
-    ],
-    [
-      [{}, "[emoji:3]", { content: "string" }],
-      (result) => {
-        expect(emojiRegex.test(result)).toBe(true);
-        expect(result.length).toBeDefined();
-      },
-      "should interpolate [emoji:3]",
-    ],
   ]);
 
   it("should return the same emoji for the same string", () => {
@@ -298,16 +281,6 @@ describe("interpolateName()", () => {
     expect(result1).toBe(result2);
   });
 
-  it("should throw error when out of emoji", () => {
-    expect(() => {
-      loaderUtils.interpolateName.apply(loaderUtils, [
-        {},
-        "[emoji:5000]",
-        { content: "foo" },
-      ]);
-    }).toThrow("Ran out of emoji");
-  });
-
   describe("no loader context", () => {
     const loaderContext = {};
     run([
