TextWatchListener is removed at onDetach so that no exception is thrown if android raise textChanged but we destroyed our android object in onDestroy of edit-text (NativeScript#2392)

Hristo Hristov · web-flow · commit 7db517858be4 · 2016-07-01T13:20:09.000+03:00
diff --git a/tests/app/ui/text-view/text-view-tests.ts b/tests/app/ui/text-view/text-view-tests.ts
@@ -481,3 +481,16 @@ export var testMemoryLeak = function (done) {
         textViewTestsNative.typeTextNatively(textView, "Hello, world!");
     }, done);
 }
+
+export function test_watch_listerer_is_removed_at_onDetach() {
+    if (platform.isAndroid) {
+        helper.buildUIAndRunTest(_createTextViewFunc(), (views: Array<viewModule.View>) => {
+            let tv = <textViewModule.TextView>views[0];
+            let page = <pagesModule.Page>tv.page;
+            let editText = tv.android;
+            editText.setText("String");
+            page.content = null;
+            editText.setText("FAIL");
+        });
+    }
+}
diff --git a/tns-core-modules/ui/editable-text-base/editable-text-base.android.ts b/tns-core-modules/ui/editable-text-base/editable-text-base.android.ts
@@ -107,8 +107,11 @@ export class EditableTextBase extends common.EditableTextBase {
     }
 
     public _onDetached(force?: boolean) {
-        this._android = undefined;
+        if (this._android && this._textWatcher) {
+            this._android.removeTextChangedListener(this._textWatcher);
+        }
 
+        this._android = undefined;
         super._onDetached(force);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -107,8 +107,11 @@ export class EditableTextBase extends common.EditableTextBase {`
`107`	`107`	`}`
`108`	`108`
`109`	`109`	`public _onDetached(force?: boolean) {`
`110`		`- this._android = undefined;`
	`110`	`+ if (this._android && this._textWatcher) {`
	`111`	`+ this._android.removeTextChangedListener(this._textWatcher);`
	`112`	`+ }`
`111`	`113`
	`114`	`+ this._android = undefined;`
`112`	`115`	`super._onDetached(force);`
`113`	`116`	`}`
`114`	`117`