feat(ingestion): add owners in create/edit ingestion source and show owners in ingestion table #13663

purnimagarg1 · 2025-05-30T11:50:21Z

Linear ticket:
https://linear.app/acryl-data/issue/CH-358/implement-adding-owners-on-step-4-of-createedit-ingestion-source
https://linear.app/acryl-data/issue/CH-347/support-displaying-owners-in-ingestion-sources-table

Screenshot:

alwaysmeticulous · 2025-05-30T12:00:53Z

✅ Meticulous spotted visual differences in 50 of 1493 screens tested, but all differences have already been approved: view differences detected.

Meticulous evaluated ~8 hours of user flows against your PR.

_{Last updated for commit dc8a9b6. This comment will update as new commits are pushed.}

codecov · 2025-05-30T15:39:25Z

Bundle Report

Changes will decrease total bundle size by 347 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
datahub-react-web-esm	19.66MB	-347 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`assets/index-*.js`	-347 bytes	16.03MB	-0.0%

Files in assets/index-*.js:

./src/app/ingest/source/builder/types.ts → Total Size: 40 bytes
./src/app/ingestV2/source/IngestionSourceList.tsx → Total Size: 15.07kB
./src/app/ingestV2/source/builder/IngestionSourceBuilderModal.tsx → Total Size: 3.66kB
./src/app/sharedV2/owners/OwnersSection.tsx → Total Size: 4.88kB
./src/app/ingest/source/builder/NameSourceStep.tsx → Total Size: 10.4kB
./src/app/tags/ManageTag.tsx → Total Size: 6.05kB
./src/app/ingestV2/source/IngestionSourceTable.tsx → Total Size: 2.73kB
./src/app/ingestV2/source/IngestionSourceTableColumns.tsx → Total Size: 5.61kB
./src/app/ingestV2/source/builder/types.ts → Total Size: 38 bytes
./src/app/ingest/source/IngestionSourceList.tsx → Total Size: 15.44kB
./src/app/ingest/source/builder/IngestionSourceBuilderModal.tsx → Total Size: 4.26kB
./src/app/ingestV2/source/builder/NameSourceStep.tsx → Total Size: 10.59kB
./src/app/tags/CreateNewTagModal/CreateNewTagModal.tsx → Total Size: 3.01kB

chriscollins3456

hm i noticed a few things when testing this PR locally:

the modal appears further down the screen than it was and the bottom of the modal has no rounded edges?

Because of that it looks like on step two the modal is getting cut off, just different than how it behaved before and feels off:

Can we make "Name" and "Owners" consistent in styling? Also, anna asked us to move the red asterisk to be after "Name" and not before

chriscollins3456 · 2025-05-30T20:57:36Z

datahub-web-react/src/app/ingestV2/source/IngestionSourceList.tsx

+                            variables: {
+                                input: {
+                                    owners,
+                                    resources: [{ resourceUrn: newSource.urn }],


i hope newSource.urn is always the urn of the newly created source instwad of PLACEHOLDER_URN - i think that should be the case right?

yes. I suppose PLACEHOLDER_URN must have been added as a fallback for null cases. But if createIngestionSource returns an urn, this will that urn only.

chriscollins3456

i also don't see the owners show up on a source when i go to edit if i'd previously added owners. maybe you're not expecting that in this PR but wanted to call it out

purnimagarg1 · 2025-06-02T13:15:02Z

i also don't see the owners show up on a source when i go to edit if i'd previously added owners. maybe you're not expecting that in this PR but wanted to call it out

this was dependent on another PR of Victor's that had backend changes to add ownership in ingestion sources. Since that is merged now, we can see the existing owners in the modal.

purnimagarg1 · 2025-06-02T13:17:14Z

Updated screenshots:

chriscollins3456

cool beans here - one request to be done in a followup to do a debounce

chriscollins3456 · 2025-06-02T14:44:32Z

datahub-web-react/src/app/sharedV2/owners/OwnersSection.tsx

+        if (text && text.trim().length > 0) {
+            autoCompleteQuery({


nice! can we add a debounce here so we don't trigger a new api call with every key stroke?

chriscollins3456 · 2025-06-02T14:45:41Z

looks like we have a failing related test src/app/ingestV2/source/builder/__tests__/NameSourceStep.test.tsx

codecov · 2025-06-02T16:03:01Z

Codecov Report

Attention: Patch coverage is 48.41270% with 195 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ct/src/app/ingestV2/source/IngestionSourceList.tsx	6.12%	46 Missing ⚠️
...eact/src/app/ingest/source/IngestionSourceList.tsx	6.52%	43 Missing ⚠️
...pp/ingestV2/source/IngestionSourceTableColumns.tsx	25.00%	27 Missing ⚠️
...eb-react/src/app/sharedV2/owners/OwnersSection.tsx	72.50%	22 Missing ⚠️
...tV2/source/builder/IngestionSourceBuilderModal.tsx	38.88%	11 Missing ⚠️
datahub-web-react/src/app/tags/ManageTag.tsx	21.42%	11 Missing ⚠️
...est/source/builder/IngestionSourceBuilderModal.tsx	35.71%	9 Missing ⚠️
...c/app/tags/CreateNewTagModal/CreateNewTagModal.tsx	11.11%	8 Missing ⚠️
...t/src/app/ingest/source/builder/NameSourceStep.tsx	81.08%	7 Missing ⚠️
...src/app/ingestV2/source/builder/NameSourceStep.tsx	84.78%	7 Missing ⚠️
... and 1 more

❌ Your patch status has failed because the patch coverage (48.41%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

purnimagarg1 · 2025-06-03T06:53:44Z

Add Owners in ingestV1:

…owners in ingestion table (datahub-project#13663)

github-actions bot added the product PR or Issue related to the DataHub UI/UX label May 30, 2025

datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label May 30, 2025

github-actions bot deployed to datahub-project-web-react (Preview) May 30, 2025 12:00 View deployment

vercel bot had a problem deploying to Preview May 30, 2025 12:03 Failure

purnimagarg1 force-pushed the CH-372-empty-loading-state-ingestion-table branch from aa69369 to 3feee4f Compare May 30, 2025 15:22

purnimagarg1 force-pushed the CH-358-add-owners-in-create-edit-ingestion branch from c528f70 to a95d281 Compare May 30, 2025 15:31

github-actions bot deployed to datahub-project-web-react (Preview) May 30, 2025 15:41 View deployment

vercel bot had a problem deploying to Preview May 30, 2025 15:55 Failure

chriscollins3456 force-pushed the CH-372-empty-loading-state-ingestion-table branch from 3feee4f to 23bbca9 Compare May 30, 2025 20:46

chriscollins3456 reviewed May 30, 2025

View reviewed changes

datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels May 30, 2025

chriscollins3456 reviewed May 30, 2025

View reviewed changes

Base automatically changed from CH-372-empty-loading-state-ingestion-table to master May 31, 2025 00:44

add owners in create/edit ingestion source

cb4c1c7

purnimagarg1 force-pushed the CH-358-add-owners-in-create-edit-ingestion branch from a95d281 to cb4c1c7 Compare June 2, 2025 06:21

github-actions bot deployed to datahub-project-web-react (Preview) June 2, 2025 06:30 View deployment

vercel bot had a problem deploying to Preview June 2, 2025 06:35 Failure

improve the modal and show owners in table column

17ab059

purnimagarg1 changed the title ~~feat(ingestion): add owners in create/edit ingestion source~~ feat(ingestion): add owners in create/edit ingestion source and show owners in ingestion table Jun 2, 2025

datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Jun 2, 2025

github-actions bot deployed to datahub-project-web-react (Preview) June 2, 2025 13:28 View deployment

vercel bot had a problem deploying to Preview June 2, 2025 13:29 Failure

chriscollins3456 approved these changes Jun 2, 2025

View reviewed changes

datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jun 2, 2025

purnimagarg1 added 2 commits June 2, 2025 20:36

fix test and add debounce

baf2f23

resolve conflicts

7c816b3

github-actions bot deployed to datahub-project-web-react (Preview) June 2, 2025 15:52 View deployment

vercel bot had a problem deploying to Preview June 2, 2025 15:56 Failure

implement adding owners in ingestV1

1963651

github-actions bot deployed to datahub-project-web-react (Preview) June 3, 2025 07:04 View deployment

vercel bot had a problem deploying to Preview June 3, 2025 07:09 Failure

fix test

dc8a9b6

github-actions bot deployed to datahub-project-web-react (Preview) June 3, 2025 13:12 View deployment

vercel bot had a problem deploying to Preview June 3, 2025 13:13 Failure

chriscollins3456 merged commit 65ae48e into master Jun 4, 2025
31 of 33 checks passed

chriscollins3456 deleted the CH-358-add-owners-in-create-edit-ingestion branch June 4, 2025 15:35

kartikey-visa pushed a commit to kartikey-visa/datahub that referenced this pull request Jul 23, 2025

feat(ingestion): add owners in create/edit ingestion source and show …

c184850

…owners in ingestion table (datahub-project#13663)

feat(ingestion): add owners in create/edit ingestion source and show owners in ingestion table #13663

feat(ingestion): add owners in create/edit ingestion source and show owners in ingestion table #13663

Uh oh!

Conversation

purnimagarg1 commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alwaysmeticulous bot commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

chriscollins3456 left a comment

Choose a reason for hiding this comment

Uh oh!

chriscollins3456 May 30, 2025

Choose a reason for hiding this comment

Uh oh!

purnimagarg1 Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

chriscollins3456 left a comment

Choose a reason for hiding this comment

Uh oh!

purnimagarg1 commented Jun 2, 2025

Uh oh!

purnimagarg1 commented Jun 2, 2025

Uh oh!

chriscollins3456 left a comment

Choose a reason for hiding this comment

Uh oh!

chriscollins3456 Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

chriscollins3456 commented Jun 2, 2025

Uh oh!

codecov bot commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

purnimagarg1 commented Jun 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

purnimagarg1 commented May 30, 2025 •

edited

Loading

alwaysmeticulous bot commented May 30, 2025 •

edited

Loading

codecov bot commented May 30, 2025 •

edited

Loading

codecov bot commented Jun 2, 2025 •

edited

Loading