-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tick and Tock Broken #378
Comments
They works in |
'tick' still works but it seems 'every' doesn't. comment it out and ticks appear again |
Problem crept in due to the update from var to let for render-marks.js Line 34 declares offset as const in local scope of the code segment that handles tick / tock value being a single number, but offset is a 'let' variable that is supposed to be available everywhere in the function. Line 34 of https://github.com/wavedrom/wavedrom/blob/trunk/lib/render-marks.js cc @drom Just removing the 'const ' from the line fixed the problem. |
https://wavedrom.com/editor.html
Tick and tock no longer work. Here's a testcase.
{signal: [
{name: 'clock', wave: 'P...........'},
],
head:{
text:'WaveDrom example',
tock:1,
every:1
}
}
The text was updated successfully, but these errors were encountered: