Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tick and Tock Broken #378

Closed
DrMatthewJApplegate opened this issue Jan 13, 2023 · 3 comments
Closed

Tick and Tock Broken #378

DrMatthewJApplegate opened this issue Jan 13, 2023 · 3 comments

Comments

@DrMatthewJApplegate
Copy link

https://wavedrom.com/editor.html

Tick and tock no longer work. Here's a testcase.

{signal: [
{name: 'clock', wave: 'P...........'},
],
head:{
text:'WaveDrom example',
tock:1,
every:1
}
}

@Timmmm
Copy link

Timmmm commented Feb 13, 2023

They works in foot but not in head.

@gmoreto
Copy link

gmoreto commented Apr 19, 2023

'tick' still works but it seems 'every' doesn't. comment it out and ticks appear again

@Ganesh-AT
Copy link

Ganesh-AT commented Apr 29, 2023

Problem crept in due to the update from var to let for render-marks.js

Line 34 declares offset as const in local scope of the code segment that handles tick / tock value being a single number, but offset is a 'let' variable that is supposed to be available everywhere in the function.

Line 34 of https://github.com/wavedrom/wavedrom/blob/trunk/lib/render-marks.js

cc @drom

Just removing the 'const ' from the line fixed the problem.

image

@drom drom closed this as completed in b3e324d Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants