- Filter::invRadius is only used in mitchell.cpp, but it is recomputed in FilmTile::FilmTile, why not pass the filter and use it directly?
- Precomputing
halfPixel
versus usingVector2f(0.5f, 0.5f)
is inconsistent. - Why is
Film::pixels
astd::unique_ptr<Pixel[]>
butFilmTile::pixels
is astd::vector<FilmTilePixel>
, why not the same for both? - Why isn't
LOOKUP_ONE
andLOOKUP_PTR
used forFindOneFloat
andFindFloat
.
- mmp/pbrt-v3#295
- Why does
ParamListItem
haveisString
, it's not used. - Why do
parseParams
andAddParam
take aSpectrumType
, it doesn't appear to be used.
- Why does