-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid Web IDL loop between NDEFRecordInit and NDEFMessageInit #620
Comments
External records allow sub-records, so it does make sense that you can create a record with other records inside it. NFC doesn't define any limit of sub records with sub records, but doing more than one or two would be quite rare. If web idl doesn't allow this, then I don't know how to spec it |
If we need to break the structural definition of recursive data, we can define a function in NDEFRecord to init its |
Maybe @littledan or @domenic have ideas here |
Prior to #454 the |
Yes, using |
My involvement with this spec is very minimal, so it'd be great if someone could make the required changes here. I can help with the implementation changes later. |
I'll work on a spec PR in the following days. |
I've started a spec PR at #621. Please let me know what you think. |
@rakuco Spec has been updated. See https://w3c.github.io/web-nfc/#creating-ndef-message and #621 |
Thank you! |
https://heycam.github.io/webidl/#idl-dictionaries says:
#454 introduced a case of 4, 5 and 6, as right now
NDEFRecordInit.data
can be anNDEFMessageInit
, which is a dictionary with a sequence ofNDEFRecordInit
s. This creates a loop that is not allowed by Web IDL and which can cause implementation issues like https://bugs.chromium.org/p/chromium/issues/detail?id=1242274The text was updated successfully, but these errors were encountered: