-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"setting all of the following" wording nitpick in normative 1.4.12: Text Spacing #930
Comments
+1 to errata: „any of“ or even „any of the following alone or in combination“. If only it wasn‘t so cumbersome. |
As an aside, we have been wondering whether it is makes sense to specify a default screen with for testing text spacing, or whether testing implies covering all potential viewport widths and page states on those views. Sometimes issues only appear in drop-down menus and other stuff, so it is rather laborious to test. |
+1 to any |
I'd be tempted to say that this applies to (and needs to be tested at) all screen sizes (with, for sanity, 320 CSS px width / 256 CSS px height as a common sense lower limit), though yes this is very laborious to test, agree. if the site has dimension-based breakpoints, testing needs to happen at each breakpoint at least, but any size in between would also theoretically need testing, IMO. |
Yes, according to WCAG 2.1: 5.2.2 Full pages: "A full page includes each variation of the page that is automatically presented by the page for various screen sizes (e.g. variations in a responsive Web page). Each of these variations needs to conform (or needs to have a conforming alternate version) in order for the entire page to conform" |
@alastc is it worth making a PR here that changes the normative wording for an errata version? |
Given that it's a one-word change, that's enough to survey. |
My (chair-hat-off) opinion:
Does it matter? If it is tested by setting all of them, that is going to provide the most change, the most likely way to break a layout. Is it worth increasing the test-overhead by testing them individually and together? That would be 4+3+2+1 = 10 combinations (if my school-level maths is correct). |
to me it's about plugging gaps that people may find by interpreting the exact wording of SCs to then later argue about whether or not something passes or fails. for testing, i'd still end up testing it together for expediency / in the knowledge that it's unlikely a site would fail for only one vs all of them. but then if later on it's found that a site did fail when only changing a particular combination, it's not a "yes but the SC normatively says it's only when all of them are changed", but more "oh ok, this was missed out in testing, but yes it fails" |
That is how I would approach it, but it sounds risky in the 3rd party auditor context, at least in the US. |
theoretically there are not 10 test cases, but infinitely many, because I would have to test all possible distances between standard and maximum value as well ("to at least") and furthermore at all screen widths |
Not from the SC text as it is now, which is to set all of them to the particular values. |
I understand "to at least" in 1.4.12 that all intermediate values must also work, such as with SC 1.4.4 also all zoom levels up to 200%. In contrast to 1.4.10, where exactly 320px are required and no intermediate levels. |
From memory, the "to at least" means you can go above those values, but you should test to 'at least' those values. It assumes that if it works at those values then it will work at lower values, but doesn't require testing of that. |
Draft response based on discussion today (mainly @mbgower's comment): The SC was written to make testing straight forward for a pass: set these 4 qualities to these levels, and you pass this SC. While there may be some scenarios where one of these alone would cause a failure where all of them did not, that is clearly an outside case, the intent was to make it straightforward & efficient. |
shame that, as with similar discussions around "up to" on the reflow SC a ages ago, ease of testing/preventing unforeseen liability for auditors takes precedence. but fair enough. |
@patrickhlauke - I think it is about practical deference to the skill set of an average well-intentioned developer who is best served by very concrete |
Noting a couple of concerns here for posterity sake. The current approach is reasonable when considering needs across the spectrum, including those of developers, but it would be helpful to document the following:
|
@rainbreaw that is a good observation that it is possible to fail 1.4.12 with just one setting (not working). But I think I am missing something. What do you mean by In the context of this particular SC, I don't think changing While I agree that setting the four qualities to the levels specified should be a sufficient test for passing this SC, the SC text requires more than that. The guidance that |
@bruce-usab based on the discussion that was had on this, and @alastc's response
so normatively the only case where this fails is if you set "all of the following" to "at least" those specified values. if you set only one of those, and leave the others alone, or you set them all to values below the ones specified, and things fail ... but through cunning an author managed to catch just the exact case normatively specified, it would fail for users, but would not fail the SC. i.e. say my page passes when setting all four properties to those specified values, but my styles do fall apart if only line height is changed to 1.5, then it normatively passes. yes those cases may be rare. but depending on how styles are set up, they could happen. for what it's worth, i made an admittedly contrived case where a script checks for one of these precise values (at the time we were discussing the "up to" / lower boundary case) https://codepen.io/patrickhlauke/full/jgVGOp - this same approach could be extended to only check for the exact 4 properties to be set to the specified values, and only kick in to "fix" the page in those cases, but break otherwise. this again would pass the SC but possibly fail users that don't set all four properties to those specified values. |
Thank you @patrickhlauke for adding the additional context on the conversation about the words "any" vs. "all." |
@alastc it's trivial, but as i just stumbled across it: was this ever surveyed? |
Argh, just lost what was a pretty long and explicit draft response to this! Short summary (probably better for everyone):
One possible action in response to this issue is to add material to the Understanding document to make this all more explicit. |
well, to be more precise: the author must allow for the text spacing metrics to be changed without adverse effect. but it's the user (via the user agent) that overrides/sets these spacing metrics, not the author...
don't have one in the wild, but as mentioned previously:
|
@patrickhlauke asked if this was surveyed. Yes. From the 25 May 2021 minutes:
|
@bruce-usab a good good. so then this can be closed (a drop in the ocean of open issues, but still) |
The normative wording for 1.4.12 currently reads
emphasis added to "setting all of the following". this may be misinterpreted as meaning that it only applies when all four properties (line height, spacing following paragraphs, letter spacing, word spacing) are set by the user.
i assume (also from the understanding document that clarifies that failures shouldn't happen for in-between values) that this actually intends to mean "setting any of the following", and if so wondering if that should be clarified in an errata or note?
The text was updated successfully, but these errors were encountered: