Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update lang switch for recent (3y) respec html change #419

Open
wants to merge 5 commits into
base: gh-pages
Choose a base branch
from
Open

update lang switch for recent (3y) respec html change #419

wants to merge 5 commits into from

Conversation

himorin
Copy link
Contributor

@himorin himorin commented Mar 4, 2024

closes #321
closes #311

@himorin himorin requested review from xfq and kidayasuo March 4, 2024 07:55
kidayasuo
kidayasuo approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@kidayasuo kidayasuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation section looks reasonable. Since I do not know respec, somebody else need to review the Javascript parts.

xfq
xfq approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@xfq xfq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kidayasuo kidayasuo kidayasuo approved these changes

@xfq xfq xfq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch the language of the title need to update multi-language script per recent respec update
3 participants
@himorin @xfq @kidayasuo