Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition: add rule for dl > div #403

Merged
merged 4 commits into from
Mar 4, 2022
Merged

Addition: add rule for dl > div #403

merged 4 commits into from
Mar 4, 2022

Conversation

stevefaulkner
Copy link
Collaborator

@stevefaulkner stevefaulkner commented Mar 3, 2022 •
edited by scottaohara
Loading

Need two conformance checkers to accept or indicate commitment to this change before it can be merged:

  • html validator
  • ibm equal access accessibility checker already had a rule that calls out this issue.
  • axe-core already has a rule that calls out this issue.
  • arc toolkit

Preview | Diff

scottaohara
scottaohara reviewed Mar 3, 2022
View reviewed changes
@scottaohara
Copy link
Member

just need to log bugs with the checkers now.

thanks steve

@scottaohara scottaohara added the needs implementation commitment Cannot merge into spec until implementations in conformance checkers has been confirmed. label Mar 3, 2022
This was referenced Mar 4, 2022
Closed
Open
@scottaohara scottaohara added Meets 2 implementations req Indicates that a spec change has met the necessary 2 implementations needed to merge. and removed needs implementation commitment Cannot merge into spec until implementations in conformance checkers has been confirmed. labels Mar 4, 2022
@scottaohara scottaohara merged commit f43d09c into gh-pages Mar 4, 2022
@scottaohara scottaohara deleted the stevefaulkner-dl-div branch March 4, 2022 00:36
@scottaohara scottaohara mentioned this pull request Apr 16, 2022
Closed
@scottaohara scottaohara changed the title add rule for dl > div Addition: add rule for dl > div May 19, 2022
scottaohara added a commit that referenced this pull request May 19, 2022
@scottaohara
Chore: add links to PRs and labels to changelog
6170845 
directly reference the following PRs in the changelog, and prepend each entry with the appropriate 'label'

related to #419

- #352
- #367 (and follow on [commit](887c772))
- #360
- #353
- #372
- #402
- #404
- #403
- #396
- #391
- #369
- #381
pkra pushed a commit to w3c/aria that referenced this pull request May 20, 2024
@scottaohara
Chore: add links to PRs and labels to changelog
f0860e5 
directly reference the following PRs in the changelog, and prepend each entry with the appropriate 'label'

related to w3c/html-aria#419

- w3c/html-aria#352
- w3c/html-aria#367 (and follow on [commit](w3c/html-aria@9cc2c0a))
- w3c/html-aria#360
- w3c/html-aria#353
- w3c/html-aria#372
- w3c/html-aria#402
- w3c/html-aria#404
- w3c/html-aria#403
- w3c/html-aria#396
- w3c/html-aria#391
- w3c/html-aria#369
- w3c/html-aria#381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottaohara scottaohara scottaohara approved these changes

@patrickhlauke patrickhlauke Awaiting requested review from patrickhlauke

Assignees
No one assigned
Labels
Meets 2 implementations req Indicates that a spec change has met the necessary 2 implementations needed to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevefaulkner @scottaohara