Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction: adds missing radio role allowance for img #381

Merged
merged 5 commits into from
Dec 13, 2021

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Dec 3, 2021

closes #380.
As noted in #212, role=radio was meant to be allowed on an img alt=foo. This corrects the mistake of that allowance not making it into the spec.


Need at least two checkers to accept this change before we can merge.


Preview | Diff

closes #380.
As noted in #212, `role=radio` was meant to be allowed on an `img alt=foo`.  This corrects the mistake of that allowance not making it into the spec.
scottaohara added a commit to scottaohara/axe-core that referenced this pull request Dec 3, 2021
A `role=radio` was meant to be an allowance for an `img alt=foo`, but it had mistakenly been left out of the spec.
ARIA in HTML is fixing this oversight, w3c/html-aria#381, so this PR is to match this added allowance.
@scottaohara scottaohara added the needs implementation commitment Cannot merge into spec until implementations in conformance checkers has been confirmed. label Dec 3, 2021
gezlemon pushed a commit to ThePacielloGroup/WAI-ARIA-Usage that referenced this pull request Dec 5, 2021
related to ARIA in HTML PR w3c/html-aria#212, `role=radio` was meant to be kept as an allowance for an `img` with an accessible name, but it didn't make it into the spec.  

w3c/html-aria#381 will add this allowance.  This PR adds this allowance.
WilcoFiers pushed a commit to dequelabs/axe-core that referenced this pull request Dec 13, 2021
…3320)

* adds role=radio to img alt=foo allowances

A `role=radio` was meant to be an allowance for an `img alt=foo`, but it had mistakenly been left out of the spec.
ARIA in HTML is fixing this oversight, w3c/html-aria#381, so this PR is to match this added allowance.

* odd whitespace fix

* Update html-elms.js

* add test for img element with valid role=radio

* Update aria-allowed-role.json
@scottaohara scottaohara added Meets 2 implementations req Indicates that a spec change has met the necessary 2 implementations needed to merge. and removed needs implementation commitment Cannot merge into spec until implementations in conformance checkers has been confirmed. labels Dec 13, 2021
@scottaohara scottaohara merged commit e25814a into gh-pages Dec 13, 2021
@scottaohara scottaohara deleted the issue_380 branch December 13, 2021 17:34
sideshowbarker pushed a commit to validator/validator that referenced this pull request Jan 21, 2022
related to ARIA in HTML PR w3c/html-aria#212, `role=radio` was meant to be kept as an allowance for an `img` with an accessible name, but it didn't make it into the spec.  

w3c/html-aria#381 will add this allowance
scottaohara added a commit that referenced this pull request May 19, 2022
directly reference the following PRs in the changelog, and prepend each entry with the appropriate 'label'

related to #419

- #352
- #367 (and follow on [commit](887c772))
- #360
- #353
- #372
- #402
- #404
- #403
- #396
- #391
- #369
- #381
pkra pushed a commit to w3c/aria that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Meets 2 implementations req Indicates that a spec change has met the necessary 2 implementations needed to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correction: Allow role=radio on img alt=foo
1 participant