-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correction: adds missing radio role allowance for img #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottaohara
added a commit
to scottaohara/axe-core
that referenced
this pull request
Dec 3, 2021
A `role=radio` was meant to be an allowance for an `img alt=foo`, but it had mistakenly been left out of the spec. ARIA in HTML is fixing this oversight, w3c/html-aria#381, so this PR is to match this added allowance.
gezlemon
pushed a commit
to ThePacielloGroup/WAI-ARIA-Usage
that referenced
this pull request
Dec 5, 2021
related to ARIA in HTML PR w3c/html-aria#212, `role=radio` was meant to be kept as an allowance for an `img` with an accessible name, but it didn't make it into the spec. w3c/html-aria#381 will add this allowance. This PR adds this allowance.
WilcoFiers
pushed a commit
to dequelabs/axe-core
that referenced
this pull request
Dec 13, 2021
…3320) * adds role=radio to img alt=foo allowances A `role=radio` was meant to be an allowance for an `img alt=foo`, but it had mistakenly been left out of the spec. ARIA in HTML is fixing this oversight, w3c/html-aria#381, so this PR is to match this added allowance. * odd whitespace fix * Update html-elms.js * add test for img element with valid role=radio * Update aria-allowed-role.json
sideshowbarker
pushed a commit
to validator/validator
that referenced
this pull request
Jan 21, 2022
related to ARIA in HTML PR w3c/html-aria#212, `role=radio` was meant to be kept as an allowance for an `img` with an accessible name, but it didn't make it into the spec. w3c/html-aria#381 will add this allowance
scottaohara
added a commit
that referenced
this pull request
May 19, 2022
pkra
pushed a commit
to w3c/aria
that referenced
this pull request
May 20, 2024
directly reference the following PRs in the changelog, and prepend each entry with the appropriate 'label' related to w3c/html-aria#419 - w3c/html-aria#352 - w3c/html-aria#367 (and follow on [commit](w3c/html-aria@9cc2c0a)) - w3c/html-aria#360 - w3c/html-aria#353 - w3c/html-aria#372 - w3c/html-aria#402 - w3c/html-aria#404 - w3c/html-aria#403 - w3c/html-aria#396 - w3c/html-aria#391 - w3c/html-aria#369 - w3c/html-aria#381
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Meets 2 implementations req
Indicates that a spec change has met the necessary 2 implementations needed to merge.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #380.
As noted in #212,
role=radio
was meant to be allowed on animg alt=foo
. This corrects the mistake of that allowance not making it into the spec.Need at least two checkers to accept this change before we can merge.
Preview | Diff