Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

further alignment with accName description updates #444

Merged
merged 3 commits into from
Nov 28, 2022

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Oct 28, 2022

This PR is necessary to fully address the needs of the accName PR - w3c/accname#69

  • New language has been added to the introduction of this section, better aligning it with the normative text of accName's new 4.2 section.
  • cut down item 1 the text was redundant per the new language added to the introduction of the section.
  • Modified each of the section 2 items to align with the accName table column "how to compute description".
  • Revised the final item (4) to align with the accName normative text, and the revised introduction of this section, stating that UAs are even expected to return an empty description.

Preview | Diff

This PR is necessary to fully address the needs of the accName PR - w3c/accname#69

- New language has been added to the introduction of this section, better aligning it with the normative text of accName's new 4.2 section.
- cut down item 1 the text was redundant per the new language added to the introduction of the section.
- Modified each of the section 2 items to align with the accName table column "how to compute description".
- Revised the final item (4) to align with the accName normative text, and the revised introduction of this section, stating that UAs are even expected to return an empty description.
@JAWS-test
Copy link

For some elements we have now:

use the text equivalent computation of the subtree

and for others

use the subtree

Is the difference intentional?

@scottaohara
Copy link
Member Author

yup. I'm specifically using terminology from the accName PR this is meant to go along with. If this is accepted, then there would be follow on work to revise other sections of the spec to use consistent wording.

@scottaohara
Copy link
Member Author

direct link to changed section in the diff version of the preview - https://pr-preview.s3.amazonaws.com/w3c/html-aam/444/45c9b49...d9ae599.html#accdesc-computation

@accdc
Copy link

accdc commented Nov 17, 2022

@MelSumner Can you please review at your earliest convenience? All other PRs are on hold until this can be merged since all will require rebasing afterwards.

Copy link

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 :shipit:

@scottaohara scottaohara merged commit 9c00755 into gh-pages Nov 28, 2022
@scottaohara scottaohara deleted the further-description-updates branch November 28, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants