Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining elements to revise mapping #373

Closed
21 tasks done
scottaohara opened this issue Mar 7, 2022 · 3 comments · Fixed by #426
Closed
21 tasks done

Remaining elements to revise mapping #373

scottaohara opened this issue Mar 7, 2022 · 3 comments · Fixed by #426

Comments

@scottaohara
Copy link
Member

scottaohara commented Mar 7, 2022

Closing #229, #183 and #346 in favor of this new issue to simplify.

The following elements should map to generic, but we will either need a call out here, or in CORE AAM how AT should treat an 'inline' vs a 'block'/other display type generic (if not doing something with w3c/aria#996).

  • area no href
  • b
  • i
  • data
  • samp
  • kbd
  • pre
  • q
  • s
  • small
  • u
  • var (or maybe this is also role=code? )

the following need to be changed to 'no corresponding role' until their mappings can be finalized - covered in #376

  • dd
  • dt

questions on the following

  • bdi / bdo (change to generic or leave as a 'no corresponding role'?)
  • cite (change to generic or leave as a 'no corresponding role'?)
  • abbr (change to generic or leave as a 'no corresponding role'?)
  • address (change to generic or map to group?)
  • figcaption still map to caption even though it won't provide the figure a name anymore? (i think it might be ok, but want others opinions)
  • label, this stay as no corresponding role? We aren't moving forward with a label role, are we? Could this actually be another instance of caption? is this a generic if not?
  • legend same as above?
scottaohara added a commit that referenced this issue Mar 12, 2022
related to resolving #373.  These elements presently have no corresponding role, and their previous mappings weren't correct.  new roles are coming in future aria, see #347
@jnurthen
Copy link
Member

Proposed Deep Dive for June 30

@scottaohara
Copy link
Member Author

scottaohara commented Jun 30, 2022

From today's deep dive:

area no href - generic
b - generic
i - generic
kbd - new role (not mapped presently) - create new issue
pre - generic
q - generic
s - map to del? - create issue.
small - generic
u - generic
var - probably code? but create new issue.

bdi/bdo - generic
cite - new issue to discuss if this needs a new role.
address - group

create a new issue to merge caption, legend, and label as they all do the same thing at a high level - identify content that names another element

while <b>, and <i> were resolved to map to generic today, there was discussion about how end users will perceive no different visual representation to those element compared to <strong> and <em> - which are not generic.
'semantically' these are different from an HTML markup / "semantics" point of view. from an end user point of view, they're interchangeable. At some point I should create an issue concerning these elements to see if the HTML editors would have any concerns with us also mapping b and i to strong and emphasis.

@scottaohara
Copy link
Member Author

Other no corresponding role elements, such as iframe, audio, video, etc. likely need some sort of role for implementors, but not for authors, if not one for both. but those would also need their own issues (which may already exist in ARIA). This is specifically for accName purposes to help determine what elements can be named.

To help, HTML AAM could also indicate on a per-element basis which elements are namable vs not in the mapping tables. This goes along with other updates that need to be done to the accName section to simplify/clarify that section of the spec.

scottaohara added a commit that referenced this issue Jul 2, 2022
Per discussion `<address>` in #373, WG had no objections to mapping the element to the `group` role.
@scottaohara scottaohara added this to the ARIA 1.2 Related milestone Jul 8, 2022
scottaohara added a commit that referenced this issue Jul 9, 2022
related to #373
i, u, b, small map to generic.  Comments referring to the elements being exposed by their platform specific text styles remain in comments.

bdi/bdo map to generic. Reference writing-mode properties in comments for ia2/atk

`data` and `a no href` map to generic as decided.

also: simplifies br element mapping table
scottaohara added a commit that referenced this issue Jul 9, 2022
related to #373
i, u, b, small map to generic.  Comments referring to the elements being exposed by their platform specific text styles remain in comments.

bdi/bdo map to generic. Reference writing-mode properties in comments for ia2/atk

`data` and `a no href` map to generic as decided.

also: simplifies br element mapping table
scottaohara added a commit that referenced this issue Jul 19, 2022
* Revise address element to map to role=group
* update changelog to ref date merged.
Per discussion `<address>` in #373, WG had no objections to mapping the element to the `group` role.
aarongable pushed a commit to chromium/chromium that referenced this issue Sep 8, 2023
Update pre element to generic role according to the HTML-AAM spec[1] and
the discussion[2]. Therefore, the pre role was deprecated because it is
no longer used.

[1]: https://w3c.github.io/html-aam/#html-element-role-mappings
[2]: w3c/html-aam#373

Low-Coverage-Reason: Renaming changes only.
Bug: None
Change-Id: I7eaca4a966de762614751850787e1bcd154c8798
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4776721
Reviewed-by: Camille Lamy <[email protected]>
Commit-Queue: Hunseop Jeong <[email protected]>
Reviewed-by: David Tseng <[email protected]>
Reviewed-by: Aaron Leventhal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1194019}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants