Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-display] Inlinified 'block ruby' should generate an inline-block wrapper #1700

Closed
Loirooriol opened this issue Aug 6, 2017 · 2 comments
Closed

[css-display] Inlinified 'block ruby' should generate an inline-block wrapper #1700

Loirooriol opened this issue Aug 6, 2017 · 2 comments
Labels
Closed Rejected as Wontfix by Editor Discretion css-display-3 Current Work css-ruby-1 Current Work Tracked in DoC

Comments

@Loirooriol
Copy link
Contributor

When a block flow element is inlinified, it becomes inline flow-root (i.e. inline-block) in order to preserve the block container.

Shouldn't the same happen for block ruby? If you request your ruby container to be wrapped inside a principal block container (e.g. because you want to use width or height), shouldn't the block container be preserved (in the form of as inline-block) in case the element is unexpectedly inlinified by some ancestor?

I think so. There should be a ruby-root inner display type and, just like flow becomes flow-root during inlinification, ruby should become ruby-root.
@fantasai fantasai added the css-ruby-1 Current Work label Aug 15, 2017
@Loirooriol Loirooriol mentioned this issue Nov 7, 2017
Closed
@upsuper upsuper added the css-display-3 Current Work label Nov 8, 2017
@fantasai
Copy link
Collaborator

I don't think there's a use case for this, and letting block ruby convert to inline ruby is fine. If you want it to be atomic, you probably should be using flexbox, not the inline formatting model.

@Loirooriol
Copy link
Contributor Author

Loirooriol commented Mar 19, 2018 •
edited
Loading

@fantasai More than flexbox I guess I should separate the block ruby element into a parent with display: block and a child with display: ruby. But I don't like adding elements just for styling purposes. This could be an use-case for ::contents, though.

.block-ruby { display: block }
.block-ruby::contents { display: ruby }

@Loirooriol Loirooriol mentioned this issue May 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closed Rejected as Wontfix by Editor Discretion css-display-3 Current Work css-ruby-1 Current Work Tracked in DoC
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@upsuper @fantasai @Loirooriol