Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webkit doesn't automatically right-align Adlam #13

Open
r12a opened this issue Jan 22, 2021 · 2 comments
Open

Webkit doesn't automatically right-align Adlam #13

r12a opened this issue Jan 22, 2021 · 2 comments
Labels
doc:adlm gap The first comment in this issue is read by the gap-analysis document. i:bidi_text Bidirectional text l:ff Pular (Adlam) p:ok s:adlm x:adlm

Comments

@r12a
Copy link
Contributor

r12a commented Jan 22, 2021 •
edited
Loading

Adlam text displayed in a block element with dir set to auto should be automatically right-aligned, unless the base direction is set to LTR, like this:

Screenshot 2021-01-22 at 15 33 38

The GAP

In WebKit the text appears as follows:

Screenshot 2021-01-22 at 15 36 02

This is a serious issue, and indicates that first-strong heuristics are not being applied. Note that this was not an issue for N'Ko, Arabic, Hebrew, Thaana, or Syriac text.

Tests & results

Interactive test, Text in languages that use RTL scripts will be automatically aligned with the right side of their container when dir is set to auto

  • Gecko: ✅ Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:96.0) Gecko/20100101 Firefox/96.0
  • Blink: ✅ Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/97.0.4692.71 Safari/537.36
  • Webkit: ✅ Adlam used to be broken, but is now fixed (see the bug report). Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.2 Safari/605.1.15

Action taken

Webkit

Outcomes

This was fixed in WebKit, so it now works as expected for all 3 major browser engines.

Priority

Priority initially set to basic because this was a serious issue for Adlam users, but now set to OK.
@r12a r12a added doc:adlm gap The first comment in this issue is read by the gap-analysis document. i:bidi_text Bidirectional text p:basic The gap-analysis priority is Basic. labels Jan 22, 2021
@r12a
Copy link
Contributor Author

r12a commented Jan 22, 2021 •
edited
Loading

The first comment in this issue contains text that will automatically appear in one or more gap-analysis documents as a subsection with the same title as this issue. Any edits made to that comment will be immediately available in the document. Proposals for changes or discussion of the content can be made in comments below this point.

Relevant gap analysis documents include:
Adlam

@xfq
Copy link
Member

xfq commented Jan 23, 2021

Browser bug raised: https://bugs.webkit.org/show_bug.cgi?id=220885

@r12a r12a added the x:webkit label Apr 20, 2021
@r12a r12a added the x:adlm label May 11, 2021
@r12a r12a added p:ok and removed p:basic The gap-analysis priority is Basic. x:webkit labels Feb 3, 2022
@w3c w3c deleted a comment Jun 19, 2023
@w3c w3c deleted a comment Jun 19, 2023
@r12a r12a added the l:ff Pular (Adlam) label May 3, 2024
@r12a r12a moved this to Fixed in Gap-analysis pipeline Jun 20, 2024
@r12a r12a added the s:adlm label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc:adlm gap The first comment in this issue is read by the gap-analysis document. i:bidi_text Bidirectional text l:ff Pular (Adlam) p:ok s:adlm x:adlm
Projects
Gap-analysis pipeline
Status: Fixed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xfq @r12a