T967: Support NVMe drives in installer #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had a difficult time finding a canonical source of device name formatting in Linux (was hoping for an RFC), but this should be pretty close to reality. NVMe drives are typically named as so: - nvme0: first registered device's device controller - nvme0n1: first registered device's first namespace - nvme0n1p1: first registered device's first namespace's first partition
In the absence of this commit, the installer hangs right after: > How big of a root partition should I create?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses https://phabricator.vyos.net/T967, specifically in the context of NVMe (SSD) drives not being shown in the installer options under the "Install the image on?" step. It does so by updating a variety of places in the installer scripts where there is an overly specific grep that doesn't allow for a device naming structure like
nvme0n1.As mentioned in 7b71365, I had a difficult time finding a canonical source of device name formatting in Linux (was hoping for an RFC), but this should be pretty close to reality for NVMe drives. They're named as so:
nvme0: first registered device's device controllernvme0n1: first registered device's first namespacenvme0n1p1: first registered device's first namespace's first partitionSupport for
mmcdrives was discussed in https://phabricator.vyos.net/T967, but I classified it as out of scope for this pull request simply because I don't have a great way of testing that path.It's worth pointing out that https://phabricator.vyos.net/T955 is likely a far more robust solution to this problem, but this pull request could hold over any other users who run into a similar problem as I do until the new installer is put in place.