fix: should throw error (#55)

regou · yyx990803 · commit cde4f9d76df8 · 2017-09-08T10:07:02.000-05:00
diff --git a/src/mixin.js b/src/mixin.js
@@ -46,7 +46,7 @@ export default {
         }
         vm._obSubscriptions.push(obs[key].subscribe(value => {
           vm[key] = value
-        }))
+        }, (error) => { throw error }))
       })
     }
   },
diff --git a/test/test.js b/test/test.js
@@ -117,6 +117,29 @@ test('subscriptions() has access to component state', () => {
   expect(vm.$el.textContent).toBe('FOOBAR')
 })
 
+test('subscriptions() can throw error properly', done => {
+  const { ob, next } = mock()
+
+  const vm = new Vue({
+    subscriptions () {
+      return {
+        num: ob.startWith(1).map(n => n.toFixed())
+      }
+    },
+    render (h) {
+      return h('div', this.num)
+    }
+  }).$mount()
+
+  nextTick(() => {
+    expect(() => {
+      next(null)
+    }).toThrow()
+    expect(vm.$el.textContent).toBe('1')
+    done()
+  })
+})
+
 test('v-stream directive (basic)', done => {
   const vm = new Vue({
     template: `

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ export default {`
`46`	`46`	`}`
`47`	`47`	`vm._obSubscriptions.push(obs[key].subscribe(value => {`
`48`	`48`	`vm[key] = value`
`49`		`- }))`
	`49`	`+ }, (error) => { throw error }))`
`50`	`50`	`})`
`51`	`51`	`}`
`52`	`52`	`},`