Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean "io/ioutil" . #5729

Closed
wants to merge 1 commit into from
Closed

Conversation

yanggangtony
Copy link
Contributor

Signed-off-by: yanggang [email protected]

/kind cleanup

replaced io/ioutil with "os / io" package.

We should clean all io/util package according the url: ioutil 1.16

Signed-off-by: yanggang <[email protected]>
@blackpiglet
Copy link
Contributor

blackpiglet commented Jan 9, 2023

@yanggangtony
Thanks for your contribution, but we already made some progress in other PR #5744.
We didn't notice this PR soon enough. Could we trace the "io/ioutil" package replacement in that PR?

@yanggangtony
Copy link
Contributor Author

yanggangtony commented Jan 9, 2023

@yanggangtony Thanks for your contribution, but we already made some progress in other PR #5744. We didn't notice this PR soon enough. Could we trace the "io/ioutil" package replacement in that PR?

hi, i see another pr 5744 is about the same thing.
you means close this one? i see that one have do the same clean work .

@blackpiglet
Copy link
Contributor

@yanggangtony
Yes. I prefer to do the work in #5744.

@yanggangtony
Copy link
Contributor Author

@yanggangtony Yes. I prefer to do the work in #5744.

OK, just close these one first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants