VIVO 3838: Upgrading to 4 #379
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft of incomplete fixes that are provided as a PR for easier consumption of another developer to pick up where I am leaving off.
This is not intended to be merged as-is and will eventually be closed rather than merged into the target branch. Consider using the branch represented by this Draft PR as a starting point.
The state of these changes:
jena4-upgradebranch (This will be easier to review once that PR is merged).DatasetFactory.createGeneral()as a replacement to the once deprecated and now removedDatasetFactory.createMem().DatasetFactory.createTxnMem()cannot be used without further design changes as several tests fail and there appears to be a performance loss.Some of the incidental refactor code changes happened due to trying to cross reference the current implementation and the upstream class being overriden. I found it easier to just make the files identical and scroll up and down each until everything being overwritten matches. I added comments breaking up such files for easier comparison.
The following are some observations regarding on of the failing tests.
The
recomputeABox1test fromSimpleReasonerSameAsTestis failing.The problem appears to be associated with
ABoxRecomputer.I observed a problem where after the recompute is performed the data in the inference becomes incorrect.
The data is looking like:
When instead the data should look like:
The entire inference before recomputing looks like:
After recomputing, the data looks like:
Consider reviewing the individual commits as they may have further details regarding that given change set.