Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for groups and classnames or id's #629

Open
justis-app opened this issue Jun 30, 2024 · 2 comments · May be fixed by #647
Open

Support for groups and classnames or id's #629

justis-app opened this issue Jun 30, 2024 · 2 comments · May be fixed by #647
Labels
question Further information is requested

Comments

@justis-app
Copy link

Feature Request

This would help in css animations and making the svg's more intereactive

Description

What do you want to add to Satori, and why?
Something like id and class that allows us to select our elements from css or js
@shuding shuding added the question Further information is requested label Jul 4, 2024
@shuding
Copy link
Member

shuding commented Jul 4, 2024

Would love to make it happen, but what’s tricky here is that it might not be a 1:1 mapping between the HTML and SVG elements. Some ideas are needed.

@kruzr-app
Copy link

maybe add support for id's to be compiled and expose a Group element or a g element

@JacobLinCool JacobLinCool linked a pull request Nov 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: preserve id and class attributes JacobLinCool/satori
3 participants
@shuding @justis-app @kruzr-app