Replies: 1 comment 3 replies
-
It looks like you're using peeling as a signal for a successful overlay interaction. For that we already have the concept of accepting an overlay. There is also an |
Beta Was this translation helpful? Give feedback.
-
|
Following the docs (https://unpoly.com/closing-overlays#peeling):
In this specific situation, when a successful submission from a form that targets the parent layer, Unpoly does not dispatch the It took me a while to understand why the code I was putting into the "[up-on-accepted]" attribute was not being called. |
Beta Was this translation helpful? Give feedback.
-
|
There are many methods to close an overlay, but peeling is the only method where the user cannot control close intent (acceptance / dismissal). I'm personally only using peeling to break out of an overlay stack (e.g. a "Cancel" button), without conveying success. Maybe we could have an |
Beta Was this translation helpful? Give feedback.
-
|
From the perspective of a user who wants to avoid writing JavaScript as much as possible, being able to add an attribute to a link that opens a form and reacts to a successful submission would be extremely useful. This is a very common pattern: overlays opened to show details (only need dismissal), and overlays opened for forms (which can either succeed or fail). When a form succeeds, the overlay usually peels back to the parent layer and triggers a success message. When it fails, the current layer stays open and displays validation errors. I’ve tried other approaches, like emitting custom events from the server or matching URLs, but they all felt too complex. Having an attribute similar to [up-on-accepted] for this peeling case would make things much cleaner and better suited for this common use case. This workaround I shared for handling the peeling case works well in practice, but I’m not sure it’s the best implementation. In any case, thank you for taking the time to discuss this. You’ve built something really awesome here, and I’m extremely grateful for it. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Peeling layers is often used when a "dismiss overlay" is issued from a successful form submission from an overlay targeting the parent layer (https://unpoly.com/closing-overlays#peeling).
In order to listen to this behavior in the parent layer, one should subscribe to the "up:layer:dismissed" and check if the value equals to ":peel". It would be handy to have this case mapped to a dedicated event/attribute. On my project, I created this macro:
And I use it like this on my view/template/html:
Maybe my macro is not the best, but it made my templates clearer and it would be handy to have such behavior as a native Unpoly attribute.
Beta Was this translation helpful? Give feedback.
All reactions