Skip to content

test(eslint-plugin): improve vitest performance with isolate: false #11754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
StyleShit wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

test(eslint-plugin): improve vitest performance with isolate: false #11754

StyleShit wants to merge 2 commits into from
+1 −0

Conversation

@StyleShit
Copy link
Contributor

@StyleShit StyleShit commented Nov 11, 2025 •
edited
Loading

Trying to help a little bit with #11204

Since all (most?) eslint-plugin tests are free of side-effects, I wondered whether we can improve the performance by disabling isolation

On my local machine (M4 Pro, 24GB, Node v22.21.1), I saw an improvement of ~18% in an average of 3 runs.

If this works, we might be able to do this with other packages that have "pure" tests

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Nov 11, 2025

Thanks for the PR, @StyleShit!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Nov 11, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ba9a193
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/691398ad589ce50007760624
😎 Deploy Preview https://deploy-preview-11754--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 97 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@StyleShit StyleShit changed the title ci(eslint-plugin): improve vitest performance test(eslint-plugin): improve vitest performance Nov 11, 2025
@nx-cloud
Copy link

nx-cloud bot commented Nov 11, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit ba9a193

Command Status Duration Result
nx run-many -t lint ✅ Succeeded 3m 9s View ↗
nx run-many -t typecheck ✅ Succeeded 1m 54s View ↗
nx run integration-tests:test ✅ Succeeded 5s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 3s View ↗
nx run generate-configs ✅ Succeeded 7s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 3s View ↗
nx run types:build ✅ Succeeded 5s View ↗
Additional runs (29) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-11-11 20:20:26 UTC

@StyleShit
Copy link
Contributor Author

StyleShit commented Nov 11, 2025 •
edited
Loading

Update:

After comparing it to 3 random runs (1, 2, 3), seems like it's indeed faster (3m 26s vs 5m 10s / 5m 1s / 4m 59s)

Not sure why it fails in Node 20 though... Seems like it's flaky for some reason. Maybe there are non-pure tests after all. will investigate when I have some time

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Nov 24, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, yes! I've been meaning to test out the isolate option.

@StyleShit is this ready for review?

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Nov 24, 2025
@JoshuaKGoldberg JoshuaKGoldberg changed the title test(eslint-plugin): improve vitest performance test(eslint-plugin): improve vitest performance with isolate: true Nov 24, 2025
@StyleShit
Copy link
Contributor Author

StyleShit commented Nov 24, 2025 •
edited
Loading

Ah, no, not really
Seems like it's too flaky for some reason (see the runs history). Didn't have time to check it yet, kinda hard to reproduce. I wouldn't merge it as is

@JoshuaKGoldberg

@StyleShit StyleShit changed the title test(eslint-plugin): improve vitest performance with isolate: true test(eslint-plugin): improve vitest performance with isolate: false Nov 26, 2025
@JoshuaKGoldberg JoshuaKGoldberg removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StyleShit @JoshuaKGoldberg