fix(eslint-plugin): [no-deprecated] prevent infinite loop on alias cy… #11605
Conversation
|
Thanks for the PR, @mainframev! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 73c5e51
☁️ Nx Cloud last updated this comment at |
|
In my previous PR, I accidentally overwrote an important change and only noticed after it was merged. Should I open a separate issue to track this? |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (80.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #11605 +/- ##
==========================================
- Coverage 90.92% 90.91% -0.01%
==========================================
Files 506 506
Lines 51325 51345 +20
Branches 8469 8474 +5
==========================================
+ Hits 46665 46682 +17
- Misses 4647 4650 +3
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
mainframev
force-pushed
the
fix/no-deprecated-perf-issue
branch
from
7b612eb to
7dee4dc
Compare
mainframev
force-pushed
the
fix/no-deprecated-perf-issue
branch
from
7dee4dc to
73c5e51
Compare
If you don't mind, yes please! We don't often look at draft PRs. I'll go ahead and review this one now in the meantime. |
| let current = symbol; | ||
|
|
||
| while (tsutils.isSymbolFlagSet(current, ts.SymbolFlags.Alias)) { | ||
| /* istanbul ignore next */ |
There was a problem hiding this comment.
This'll need to be unit tested.
(I'm guessing you know this as a repeat contributor 😄 but just noting for tracking / in case someone else picks up this work)
|
👋 @mainframev are you waiting on us for anything with this PR? |
|
Thanks, no, everything is clear, I need to add proper test for this scenario and create issue. I'll get back to it asap |
2 participants
PR Checklist
Overview
This is a follow-up on #11197. The fix was originally implemented in #11359, but was inadvertently overwritten during conflict resolution and never made it into the release. We have a patch in our codebase with this change. Without this fix, our lint task enters an infinite loop both locally and on CI