Bump Chart.js from 2.9.4 to 4.2.1 in dashboard examples #38071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nitpicking, it seems the the number in the tooltip is now too close
Also, what's the reason for removing the variable? We had it there so that it's explicit. |
Haven't changed anything, it's the default rendering. But I can work on it to add some spacing between the color area and the text.
My bad, thought it was useless to affect it to something never used. Rollbacked it in 35b7a21. |
|
Added some padding in 4f4c059. Rendering is better, thanks for pointing this out :) |
mdo
approved these changes
Feb 18, 2023
XhmikosR
approved these changes
Feb 19, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR suggests to bump Chart.js version in dashboard and dashboard RTL examples from 2.9.4 to 4.2.1.
The configuration has slightly changed. There's no graphical regression; just a minor change regarding the rendering of numbers on the y-axis.
Type of changes
Checklist
npm run lint)Live previews