stop storing Article as parcelable (store id instead), remove Parcelable implementation from Article class

cthu1hoo · cthu1hoo · commit 02ba1c3b93ad · 2025-09-15T14:51:15.000+03:00
diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/ArticleFragment.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/ArticleFragment.java
@@ -83,7 +83,9 @@ public void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
 
         if (savedInstanceState != null) {
-            m_article = savedInstanceState.getParcelable("m_article");
+            int articleId = savedInstanceState.getInt("m_articleId");
+
+            m_article = Application.getArticlesModel().getById(articleId);
         }
     }
 
@@ -389,6 +391,6 @@ public void onAttach(Activity activity) {
     public void onSaveInstanceState(Bundle out) {
         super.onSaveInstanceState(out);
 
-        out.putParcelable("m_article", m_article);
+        out.putInt("m_articleId", m_article.id);
     }
 }
diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/ArticleModel.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/ArticleModel.java
@@ -431,4 +431,11 @@ public List<Article> getSelected() {
         }).collect(Collectors.toList());
     }
 
+    // returns null if not found
+    public Article getById(final int id) {
+        return m_articles.getValue().stream().filter(a -> a.id == id)
+                .findFirst()
+                .orElse(null);
+    }
+
 }
diff --git a/org.fox.ttrss/src/main/java/org/fox/ttrss/types/Article.java b/org.fox.ttrss/src/main/java/org/fox/ttrss/types/Article.java
@@ -1,8 +1,5 @@
 package org.fox.ttrss.types;
 
-import android.os.Parcel;
-import android.os.Parcelable;
-
 import org.jsoup.Jsoup;
 import org.jsoup.nodes.Document;
 import org.jsoup.nodes.Element;
@@ -16,7 +13,7 @@
 import java.util.regex.Pattern;
 
 // TODO: serialize Labels
-public class Article implements Parcelable {
+public class Article {
     public static final int TYPE_AMR_FOOTER = -2;
 
     public static final int FLAVOR_KIND_ALBUM = 1;
@@ -73,10 +70,6 @@ public class Article implements Parcelable {
     transient public String youtubeVid;
     transient public List<Element> mediaList = new ArrayList<>();
 
-    public Article(Parcel in) {
-        readFromParcel(in);
-    }
-
     public Article() {
 
     }
@@ -237,81 +230,6 @@ public Article(Article clone) {
         mediaList = new ArrayList<>(clone.mediaList);
     }
 
-    @Override
-    public int describeContents() {
-        return 0;
-    }
-
-    @Override
-    public void writeToParcel(Parcel out, int flags) {
-        out.writeInt(id);
-        out.writeInt(unread ? 1 : 0);
-        out.writeInt(marked ? 1 : 0);
-        out.writeInt(published ? 1 : 0);
-        out.writeInt(score);
-        out.writeInt(updated);
-        out.writeInt(is_updated ? 1 : 0);
-        out.writeString(title);
-        out.writeString(link);
-        out.writeInt(feed_id);
-        out.writeStringList(tags);
-        out.writeString(content);
-        out.writeString(excerpt);
-        out.writeList(attachments);
-        out.writeString(feed_title);
-        out.writeInt(comments_count);
-        out.writeString(comments_link);
-        out.writeInt(always_display_attachments ? 1 : 0);
-        out.writeString(author);
-        out.writeString(note);
-        out.writeInt(selected ? 1 : 0);
-        out.writeString(site_url);
-    }
-
-    public void readFromParcel(Parcel in) {
-        id = in.readInt();
-        unread = in.readInt() == 1;
-        marked = in.readInt() == 1;
-        published = in.readInt() == 1;
-        score = in.readInt();
-        updated = in.readInt();
-        is_updated = in.readInt() == 1;
-        title = in.readString();
-        link = in.readString();
-        feed_id = in.readInt();
-
-        if (tags == null) tags = new ArrayList<>();
-        in.readStringList(tags);
-
-        content = in.readString();
-        excerpt = in.readString();
-
-        attachments = new ArrayList<>();
-        in.readList(attachments, Attachment.class.getClassLoader());
-
-        feed_title = in.readString();
-
-        comments_count = in.readInt();
-        comments_link = in.readString();
-        always_display_attachments = in.readInt() == 1;
-        author = in.readString();
-        note = in.readString();
-        selected = in.readInt() == 1;
-        site_url = in.readString();
-    }
-
-    @SuppressWarnings("rawtypes")
-    public static final Parcelable.Creator CREATOR =
-            new Parcelable.Creator() {
-                public Article createFromParcel(Parcel in) {
-                    return new Article(in);
-                }
-
-                public Article[] newArray(int size) {
-                    return new Article[size];
-                }
-            };
-
     /**
      * set fields which might be missing during JSON deserialization to sane values
      */

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,9 @@ public void onCreate(Bundle savedInstanceState) {`
`83`	`83`	`super.onCreate(savedInstanceState);`
`84`	`84`
`85`	`85`	`if (savedInstanceState != null) {`
`86`		`- m_article = savedInstanceState.getParcelable("m_article");`
	`86`	`+ int articleId = savedInstanceState.getInt("m_articleId");`
	`87`	`+`
	`88`	`+ m_article = Application.getArticlesModel().getById(articleId);`
`87`	`89`	`}`
`88`	`90`	`}`
`89`	`91`
`@@ -389,6 +391,6 @@ public void onAttach(Activity activity) {`
`389`	`391`	`public void onSaveInstanceState(Bundle out) {`
`390`	`392`	`super.onSaveInstanceState(out);`
`391`	`393`
`392`		`- out.putParcelable("m_article", m_article);`
	`394`	`+ out.putInt("m_articleId", m_article.id);`
`393`	`395`	`}`
`394`	`396`	`}`
Original file line number	Diff line number	Diff line change
`@@ -431,4 +431,11 @@ public List<Article> getSelected() {`
`431`	`431`	`}).collect(Collectors.toList());`
`432`	`432`	`}`
`433`	`433`
	`434`	`+ // returns null if not found`
	`435`	`+ public Article getById(final int id) {`
	`436`	`+ return m_articles.getValue().stream().filter(a -> a.id == id)`
	`437`	`+ .findFirst()`
	`438`	`+ .orElse(null);`
	`439`	`+ }`
	`440`	`+`
`434`	`441`	`}`