-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Description
Setup: GDrive + Companion (on Heroku) with Redis + React Dashboard + S3 Multipart
Steps to Reproduce:
0 Login to google drive
1 Select picture (or any other file) from google drive
2 Click upload
3 On complete-event check uploadURL is defined
Expected:
uploadURL points to the S3 Url the file is located at
Actual:
uploadURL is null
In the entire result handed to the on-success handler the S3 url nowhere to be spotted
Looking in the bucket, the file was uploaded to S3
Debugging the traffic to wss:///api/, the latest event was
{"action":"success","payload":{"response":{"responseText":"{"ETag":"\"...\"","VersionId":"...","Location":"https://.s3.ap-southeast-2.amazonaws.com/uppy-file-00000000-0000-0000-0000-000000000000","key":"...","Key":"...","Bucket":"..."}","headers":{"content-type":"application/json"}},"complete":true,"url":null}} -> The url is no extracted from the S3-response!!
My debugging efforts:
I believe the url should not be null here:
https://github.com/transloadit/uppy/blob/master/packages/%40uppy/companion/src/server/Uploader.js#L483 , but instead parsed out of data (as in responseText: JSON.stringify(data))
Other notes: Uploading a local file to S3 works like a charm and returns the uploadURL correctly