Refactor: Add readMulticall route for batch contract reads #773
Conversation
|
changelog |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
| // Encode each read call | ||
| const encodedCalls = await Promise.all( | ||
| calls.map(async (call) => { | ||
| const contract = await getContract({ |
There was a problem hiding this comment.
You don't have to await getContract btw
| Reply: Static<typeof responseSchema>; | ||
| }; | ||
|
|
||
| export async function readMulticall(fastify: FastifyInstance) { |
There was a problem hiding this comment.
Small nit and non-blocking: I started calling route names readMulticallRoute. The reason is we have so many exported functions that end up having the same name (for example: createAccessToken might be the route, or the cached call, or the raw db call, who knows?)
So having that suffix is nice for clarity.
|
|
||
| const readMulticallRequestSchema = Type.Object({ | ||
| calls: Type.Array(readCallRequestItemSchema), | ||
| multicallAddress: Type.Optional(Type.String()), |
There was a problem hiding this comment.
Add a description so people know they don't need to set this:
Override a specific multicall contract. Defaults to Multicall3.
| schema: { | ||
| summary: "Batch read from multiple contracts", | ||
| description: | ||
| "Execute multiple contract read operations in a single call using Multicall3", |
There was a problem hiding this comment.
IMO don't need to mention multicall3 as it's a low level implementation detail. You can refer to "using multicall" since that's a web3 concept.
| value: 0n, | ||
| }); | ||
|
|
||
| const calldata = await resolvePromisedValue(transaction.data); |
There was a problem hiding this comment.
Don't use resolvePromisedValue. I should add a @deprecated tag on the function. Use this instead:
import { encode } from "thirdweb";
const callData = await encode(transaction);
| // stubbing gas values so that the call can be encoded | ||
| maxFeePerGas: 30n, | ||
| maxPriorityFeePerGas: 1n, | ||
| value: 0n, |
There was a problem hiding this comment.
Do these need to be stubbed? What happens if we leave them undefined?
|
|
||
| return { | ||
| success, | ||
| result: success ? bigNumberReplacer(decoded) : null, |
There was a problem hiding this comment.
We should not need bigNumberReplacer. We're on v5 SDK which does not rely on ethers.
| description: | ||
| "Execute multiple contract read operations in a single call using Multicall3", | ||
| tags: ["Contract"], | ||
| operationId: "readMulticall", |
There was a problem hiding this comment.
readBatch is preferred since "multicall" is the underlying approach but the use case is a batch read.
Test with example curl:
PR-Codex overview
This PR primarily focuses on adding support for batch reading multiple contract calls using
Multicall3in thesrc/server/routes/contract/read/read-batch.tsfile. It also updates various dependencies to their latest versions.Detailed summary
thirdwebdependency from5.61.3to5.69.0.readMulticallfunction to handle batch read operations insrc/server/routes/contract/read/read-batch.ts.readMulticallinsrc/server/routes/index.ts.package.jsonandyarn.lock.