feat: support HashSet#contains logic for changed hashCodes #3607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat3e
force-pushed
the
3.x
branch
3 times, most recently
from
e4fc1ab to
eb7b3ba
Compare
Member
|
@mat3e there are build failure because the code needs to be java 8 compatible. |
assertj-core/src/test/java/org/assertj/core/api/hashset/HashSetAssert_contains_Test.java
Outdated
Show resolved
Hide resolved
assertj-core/src/test/java/org/assertj/core/api/hashset/HashSetAssert_contains_Test.java
Outdated
Show resolved
Hide resolved
mat3e
force-pushed
the
3.x
branch
7 times, most recently
from
e846bac to
8a37259
Compare
Contributor
Author
|
I allowed myself to resolve the conversations. Took me longer than I thought, but should be good now. It's probably a breaking change, but #1104 is now assigned to |
Contributor
Author
|
I haven't yet updated |
scordio
force-pushed
the
main
branch
2 times, most recently
from
b6e46b9 to
3f3b814
Compare
Member
|
Integrated thanks @mat3e ! |
Contributor
Author
Wow, thanks! I wanted to fix remaining classes during next longer time off from ordinary work, but glad you did it 😇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List:
Following the contributing guidelines will make it easier for us to review and accept your PR.