Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise warning and abort formatting if we encounter ddl #243

Closed
tconbeer opened this issue Aug 17, 2022 · 1 comment · Fixed by #284
Closed

Raise warning and abort formatting if we encounter ddl #243

tconbeer opened this issue Aug 17, 2022 · 1 comment · Fixed by #284
Labels
enhancement New feature or request
Milestone
v0.12.0

Comments

@tconbeer
Copy link
Owner

tconbeer commented Aug 17, 2022 •
edited
Loading

create, insert, grant, etc., should raise a warning if parsed and we shouldn't try to format those queries. Should get added to a "skipped" count in the report

Or probably better to parse create...; as a DATA token. That way for files w/ DDL and a select statement we can still format the select statement.

Tracking issue for all of the different statements to parse: #262
@tconbeer tconbeer added the enhancement New feature or request label Aug 17, 2022
@tconbeer tconbeer added this to the 0.12.0 milestone Aug 22, 2022
@tconbeer
Copy link
Owner Author

Raising a warning doesn't make much sense. We're just going to parse these as data and add support for common ddl asap.

@tconbeer tconbeer mentioned this issue Oct 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging a pull request may close this issue.

Feature: Detect unsupported SQL commands and abort formatting tconbeer/sqlfmt
1 participant
@tconbeer