-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add number separators to query history results #437
Comments
@tconbeer can i take this up ? |
Yes please!! |
Some help here, but you may get stuck on the snapshot tests, which is totally fine. If I have time I'll try to record a short video on how to update those. |
@code-master-ajay Walkthrough video has been added to that page in the docs, including a walkthrough of the process for updating snapshot tests, which I think you'll have to do after you make this change. (lmk if you get stuck, though) |
Thanks a lot @tconbeer will do this asap. |
Hi @tconbeer , i followed your Walkthrough video, but when i run the
I tried running :
But it is already present in the toml file, can you help me out here OS: Ubuntu 22 Upon further investigation i think the stub for " importlib_metadata " is not present, not sure if this is the reason. |
re: mypy, this happens because there is a setting to tell mypy to lint for Python 3.8, but you're running Python 3.10; importlib_metadata is a backport that is only installed on older pythons, so mypy expects it (since it's linting against 3.8), but can't find it. |
just a tweak to the f-string here:
harlequin/src/harlequin/history.py
Line 26 in a78944f
The text was updated successfully, but these errors were encountered: