Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScanPe Fix for Dictionary / Flag Type Change (Fix for #433) #434

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

phutelmyer
Copy link
Contributor

@phutelmyer phutelmyer commented Feb 12, 2024

Describe the change
As noted in #433, two conditionals were flipped to incorrect logic, causing a mix of types in string and dictionary fields. This change fixes those conditionals to be more accurate to the original intent.

Closes #433.

Describe testing procedures
Reran tests with valid output

Sample output
N/A

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of and tested my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@phutelmyer phutelmyer linked an issue Feb 12, 2024 that may be closed by this pull request
@phutelmyer phutelmyer marked this pull request as ready for review February 12, 2024 18:38
@phutelmyer phutelmyer merged commit 25dbd8a into master Feb 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ScanPe adds dictionary to flags array
1 participant