Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements: JNLP Signature, ScanEmail Preview Image, IOC Support, and Dependency Optimization #431

Merged
merged 9 commits into from
Jan 29, 2024

Conversation

phutelmyer
Copy link
Contributor

@phutelmyer phutelmyer commented Jan 29, 2024

Describe the change

  • Added (readded?) a YARA taste for JNLP signatures
  • Enhanced ScanEmail to capture a preview image of the email and output it as base64
  • Introduced IOC (Indicators of Compromise) support for URLs in scanjavascript and scanpdf modules
  • Removed or changed some dependencies

This pull request aims to improve the functionality of Strelka by adding support for JNLP signatures, enhancing email scanning with image preview capture, and extending IOC support for URLs in relevant modules. Additionally, it optimizes the project by modifying certain dependencies.

Describe testing procedures
All scanner tests have been updated and validated.

Sample output

ScanEmail Image Preview
image

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of and tested my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@phutelmyer phutelmyer added enhancement New feature or request dependencies Pull requests that update a dependency file labels Jan 29, 2024
@phutelmyer
Copy link
Contributor Author

This will close #424, #428, #423

@phutelmyer phutelmyer marked this pull request as ready for review January 29, 2024 16:24
@phutelmyer phutelmyer merged commit b37e761 into master Jan 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant