Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard Chinese Pinyin Bugs #2

Closed
Ferrick90 opened this issue Feb 1, 2016 · 5 comments
Closed

Keyboard Chinese Pinyin Bugs #2

Ferrick90 opened this issue Feb 1, 2016 · 5 comments
Assignees

Comments

@Ferrick90
Copy link

Once I changed keyboard input to Chinese Pinyin. Found this:
textinput_bugs

Regards,
Ferrick

@szweier
Copy link
Owner

szweier commented Feb 1, 2016

I'm not entirely sure what the expectation vs. current implementation is here. Would you be able to add a test as a PR that I could possibly try to fix that way. Thanks.

@szweier szweier self-assigned this Feb 2, 2016
@Ferrick90
Copy link
Author

The expectation result should be
expectation

The keyboard will auto include with blue color when I type wo = 我. Current result becomes w哦 and w don't include with the blue color. Hope you can understand it. My english is not very well.

Thanks.

@Ferrick90
Copy link
Author

Swift version: Issue come from SZMentionsListener.swift line 153

textView.attributedText = mutableAttributedString as! NSAttributedString

@szweier
Copy link
Owner

szweier commented Feb 2, 2016

Thanks that helps. I'll take a look and let you know when it's fixed.

@szweier
Copy link
Owner

szweier commented Feb 2, 2016

@Ferrick90 the PRs below contain what I believe to be the fix for this issue. Please give it a try and let me know that it's working for you. If it is I will merge it and make a new release.

ObjC - #3
Swift - szweier/SZMentionsSwift#1

@szweier szweier closed this as completed Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants