Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New feature to specify theme package fails when not already installed #16731

Closed
downward-funarg opened this issue Dec 17, 2024 · 3 comments · Fixed by #16733
Closed

New feature to specify theme package fails when not already installed #16731

downward-funarg opened this issue Dec 17, 2024 · 3 comments · Fixed by #16733

Comments

@downward-funarg
Copy link
Contributor

#16691 allows one to specify the theme location like this:

(modus-operandi-tinted :package modus-themes)

This fails if the package isn't yet installed, e.g. if it is specified in dotspacemacs-additional-packages on a fresh install or package update, with the error

Wrong type argument: symbolp, (modus-operandi-tinted :package modus-themes)
@sunlin7
Copy link
Contributor

sunlin7 commented Dec 17, 2024

I'm trying to reproduce it...

@sunlin7 sunlin7 mentioned this issue Dec 18, 2024
Merged
@sunlin7
Copy link
Contributor

sunlin7 commented Dec 18, 2024

Solution pushed, please help verify it. Thanks

@downward-funarg
Copy link
Contributor Author

Works for me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

* core/core-themes-support.el: Fix guess theme failed sunlin7/spacemacs
2 participants
@sunlin7 @downward-funarg