Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: convert ErrorHandlingRationale from .rst to .md #62318

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

MaxDesiatov
Copy link
Contributor

Resolves partially #49997.

@MaxDesiatov
Copy link
Contributor Author

@swift-ci please smoke test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci please smoke test and merge

@@ -1,5 +1,62 @@
# Error Handling Rationale and Proposal

- [Error Handling Rationale and Proposal](#error-handling-rationale-and-proposal)
Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis Dec 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think this one is necessary, and it makes the table even more nested.

Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis Dec 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the tests are failing I will take this opportunity to also suggest adding a heading to the table, as in GettingStarted.md or ARCOptimization.md.

@MaxDesiatov
Copy link
Contributor Author

@swift-ci please smoke test and merge

@MaxDesiatov MaxDesiatov force-pushed the maxd/docs-error-handling-rationale branch from 735aca2 to d422594 Compare December 5, 2022 13:44
@swift-ci swift-ci merged commit 511d78b into main Dec 5, 2022
@swift-ci swift-ci deleted the maxd/docs-error-handling-rationale branch December 5, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants