Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide more relative Method #2

Open
suryapratapsinghsuryavanshi opened this issue Oct 1, 2021 · 9 comments · Fixed by #4, #13, #14, #23 or #24
Open

Provide more relative Method #2

suryapratapsinghsuryavanshi opened this issue Oct 1, 2021 · 9 comments · Fixed by #4, #13, #14, #23 or #24
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@suryapratapsinghsuryavanshi
Copy link
Owner

With web application all the time we face many problems to implement some logic, but in logic, we want some common mathematical applications like GCD, sum of all digits and this makes our implementation more complex hence If you want all these common math problems solved, then you can use solverjs. SolverJS are a combination of many common mathematical and some very used logic solutions.

So we created many ways to solve the problem but you also added some more methods to make web dev easier.
@DevsNight
Copy link
Contributor

I contributed. #3

@suryapratapsinghsuryavanshi suryapratapsinghsuryavanshi added the enhancement New feature or request label Oct 1, 2021
@Rohit484
Copy link
Contributor

Rohit484 commented Oct 2, 2021

JavaScript library

@suryapratapsinghsuryavanshi suryapratapsinghsuryavanshi linked a pull request Oct 3, 2021 that will close this issue
Optimized fac & sumOfN functions #4
Merged
@saranshsaini
Copy link
Contributor

saranshsaini commented Oct 6, 2021 •
edited
Loading

I made a pull request #13 to optimize the getFib method to linear time rather than exponential.

There are other optimizations that can be made, let me know if I can go ahead and make pull requests for those as well after #13 is merged and confirmed.

@suryapratapsinghsuryavanshi
Copy link
Owner Author

I made a pull request #13 to optimize the getFib method to linear time rather than exponential.

There are other optimizations that can be made, let me know if I can go ahead and make pull requests for those as well after #13 is merged and confirmed.

Thanks, optimization is a major issue please contribute your way in further away as well.

@suryapratapsinghsuryavanshi suryapratapsinghsuryavanshi linked a pull request Oct 6, 2021 that will close this issue
Optimize getFib using DP #13
Merged
@saranshsaini
Copy link
Contributor

Ok sounds good. I just made another optimization that you can check out. I will look out for more.

@suryapratapsinghsuryavanshi
Copy link
Owner Author

Yes @saranshsaini, I have reviewed it, please consider my opinion and let me know.

@suryapratapsinghsuryavanshi suryapratapsinghsuryavanshi linked a pull request Oct 6, 2021 that will close this issue
Optimize printFib using lists to build strings #14
Merged
@shyam-2002 shyam-2002 mentioned this issue Oct 20, 2021
Merged
@shyam-2002
Copy link
Contributor

Hi, I have optimized the power function. Please go through my PR #22 .

@saranshsaini
Copy link
Contributor

Hello, I made a quick fix #23 for reverseNumber so that it works properly for negative numbers. Let me know if you will merge it.

@suryapratapsinghsuryavanshi
Copy link
Owner Author

Hello, I made a quick fix #23 for reverseNumber so that it works properly for negative numbers. Let me know if you will merge it.

Yeah, I merged it.

This was linked to pull requests Oct 20, 2021
Make reverseNumber work for negative numbers #23
Merged
added transpose of matrix #24
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
5 participants
@shyam-2002 @Rohit484 @saranshsaini @suryapratapsinghsuryavanshi @DevsNight