Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: readme hashlinks fix #158

Merged
merged 1 commit into from
Sep 17, 2022

Conversation

ryanrussell
Copy link
Contributor

Signed-off-by: Ryan Russell [email protected]

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.

What is the motivation?

The install hashlinks targets in README.md end up rendering like this:

"#-------------------------------------run-using-docker"

What does this change do?

  • eliminate the white space around the icons in the hashtag links fixes the 4 install hashlinks
  • server-side-code needed updates

What is your testing strategy?

Click the links! :)

Is this related to any issues?

na

Have you read the Contributing Guidelines?

@tobiemh
Copy link
Member

tobiemh commented Sep 17, 2022

Thanks for this @ryanrussell 👏👍!

@tobiemh tobiemh merged commit 59be26e into surrealdb:main Sep 17, 2022
@ryanrussell ryanrussell deleted the refactor-readme-hashlinks-fix branch September 17, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants